[FOLIO-3043] Upgrade vertx-pac4j to Vertx .4 Created: 28/Feb/21 Updated: 05/Mar/21 Resolved: 05/Mar/21 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | TBD |
| Reporter: | Adam Dickmeiss | Assignee: | Adam Dickmeiss |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||
| Sprint: | CP: sprint 108, CP: sprint 109 | ||||||||||||||||
| Story Points: | 1 | ||||||||||||||||
| Development Team: | Core: Platform | ||||||||||||||||
| Description |
|
In order to upgrade mod-login-saml to use RMB 33, which is Vert.4 based we also need vertx-pac4j to be Vertx.4 based. The latest release and master is still Vert.x 3.9. And there seems not to be a Vert.x 4 based version around. https://github.com/pac4j/vertx-pac4j |
| Comments |
| Comment by Adam Dickmeiss [ 28/Feb/21 ] |
|
PR here: https://github.com/pac4j/vertx-pac4j/pull/161 We don't need this to be merged. We could even just bundle with mod-login-saml or publish the artifact ourserles. |
| Comment by Adam Dickmeiss [ 01/Mar/21 ] |
|
Looks like the PR is not going be part of a vertx-pac4j release soon. Bundle with mod-login-saml OR publish it ourselves like we do with vertx- {pg,sql}-client? |
| Comment by Adam Dickmeiss [ 05/Mar/21 ] |
|
Nobody has rejected on the PR .. we use it in FOLIO's vertx-pac4j version. |