[FOLIO-2985] Create mod-ebsconet github repository and add to CI Created: 27/Jan/21  Updated: 23/Feb/21  Resolved: 22/Feb/21

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Story Priority: P3
Reporter: Andrei Makaranka Assignee: David Crossley
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Defines
defines UXPROD-190 Create/Renew orders in FOLIO from EBS... Closed
Gantt End to Start
has to be done before MODEBSNET-1 Project setup in GitHub: mod-ebsconet Closed
Relates
relates to FOLIO-3025 Add mod-ebsconet to testing/snapshot ... Closed
Sprint: DevOps Sprint 107, DevOps Sprint 108, DevOps Sprint 106
Development Team: FOLIO DevOps

 Description   

Purpose:

In Acquisitions (Acquisitions github team) need to implement integration with third party EBSCONET UXPROD-190 Closed in the business module : mod-ebsconet.

Acceptance Criteria:

The repository mod-ebsconet is created and added to the (Acquisitions github team)
Members of (Acquisitions github team) team can create and merge branches
CI has been setup for the repository, including Jenkins builds and SonarQube analysis

See some guidelines at https://dev.folio.org/guidelines/create-new-repo/



 Comments   
Comment by David Crossley [ 27/Jan/21 ]

Created a new empty repo: https://github.com/folio-org/mod-ebsconet
and configured Team access.

So it is ready for you to add initial code.
Then the Jenkinsfile can be committed directly to master branch. That will do the base Sonar scan.

See some guidelines at https://dev.folio.org/guidelines/create-new-repo/

After the first pull-request, then i can finalise the branch protection settings.

Comment by Andrei Makaranka [ 02/Feb/21 ]

Hi David Crossley
Thanks.

Comment by David Crossley [ 18/Feb/21 ]

Now that code is in place, i have finalised the repository branch protection.

Comment by David Crossley [ 18/Feb/21 ]

The "api-lint" tool is reporting that the file "src/main/resources/swagger.api/ebsconet.yaml" is empty.

Would not that be crucial for your application?

(The api-lint tool missed flagging this edge case as an error, so it was not emblazoned on the PR page. See the Jenkins Artifact "ApiLintReport".)

Comment by David Crossley [ 18/Feb/21 ]

The "descriptors/*-template.json" have incorrect Maven replacement tokens. See FOLSPRINGS-4 Closed .

Does this error come from some project creation template for the Spring Way teams? We still see it happening in many modules.

Comment by David Crossley [ 18/Feb/21 ]

As explained at https://dev.folio.org/guidelines/create-new-repo/ Please add a link to your Jira issue tracker, so that people know where to report issues.

Comment by Max Shtanko [ 22/Feb/21 ]

Hi David Crossley,

I corrected *Descriptor-template.json files to match Spring-way format.

Yet, fileĀ src/main/resources/swagger.api/ebsconet.yaml is still empty for time being. Can you please point to the Jenkins Artifact "ApiLintReport" you mentioned above, so I will check it? Thank you.

Comment by David Crossley [ 23/Feb/21 ]

https://dev.folio.org/guides/api-lint/#reports

Generated at Thu Feb 08 23:24:44 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.