[FOLIO-2975] Add eslint warnings to PR for UI modules Created: 22/Jan/21  Updated: 22/Jan/21

Status: Open
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: New Feature Priority: TBD
Reporter: Ian Hardy Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Sprint:
Development Team: FOLIO DevOps

 Description   

Currently, if there are errors from eslint on a PR for a UI module, the PR is marked up with the report. Change this so warnings are also reported on PRs.

Pipeline: https://github.com/folio-org/jenkins-pipeline-libs/blob/master/vars/runLintNPM.groovy#L30

From Viktor Soroka :https://folio-project.slack.com/archives/C58TABALV/p1610357165141700

I have a question regarding running of eslint on the CI for UI modules.
1) I found that when there are only warnings found they are not placed in the form of the comment in the PR.
2) But when there is at least one error then all warnings and errors are placed as a comment.
I think that it makes sense for the first case to add the comment too. Could someone check this?
...
Hi @Ian, we discussed on #stripes-architecture to make the change FOLIO wide to show warnings always. Could you please clarify what is workflow to make that change by the devops team?


Generated at Thu Feb 08 23:24:39 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.