|
Currently, if there are errors from eslint on a PR for a UI module, the PR is marked up with the report. Change this so warnings are also reported on PRs.
Pipeline: https://github.com/folio-org/jenkins-pipeline-libs/blob/master/vars/runLintNPM.groovy#L30
From Viktor Soroka :https://folio-project.slack.com/archives/C58TABALV/p1610357165141700
I have a question regarding running of eslint on the CI for UI modules.
1) I found that when there are only warnings found they are not placed in the form of the comment in the PR.
2) But when there is at least one error then all warnings and errors are placed as a comment.
I think that it makes sense for the first case to add the comment too. Could someone check this?
...
Hi @Ian, we discussed on #stripes-architecture to make the change FOLIO wide to show warnings always. Could you please clarify what is workflow to make that change by the devops team?
|