[FOLIO-2972] Allow Lokalise updates to bypass CI code checks Created: 21/Jan/21 Updated: 02/Feb/21 Resolved: 02/Feb/21 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | Continuous Integration |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | TBD |
| Reporter: | Peter Murray | Assignee: | John Malconian |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||
| Sprint: | DevOps Sprint 107 | ||||||||
| Development Team: | FOLIO DevOps | ||||||||
| Description |
|
The pull requests made by the lokalise-to-github script are made in such a way that they have no impact on CI tests. More specifically, the script explicitly excludes changes to en.json files...the only changes that are made are to non-en.json. The UI test harness does not use language choices other than en.json. Because the JSON files from Lokalise are machine-generated, we have some confidence that they will be well-formed and do not need to be tested. So all of the CI jobs that run the UI test harnesses are redundant. |
| Comments |
| Comment by John Malconian [ 02/Feb/21 ] |
|
Peter Murray I went ahead and implemented this while I was working on something else. Whenever the last commit is made by Git author, 'FOLIO Translations Bot', the unit tests are skipped. |