[FOLIO-2951] Refer from dev.f.o to Wiki Pull Request Guidelines Created: 08/Jan/21 Updated: 26/Jan/21 Resolved: 26/Jan/21 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P2 |
| Reporter: | David Crossley | Assignee: | David Crossley |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||
| Sprint: | DevOps: Sprint 105, DevOps Sprint 106 | ||||||||||||
| Development Team: | FOLIO DevOps | ||||||||||||
| Description |
|
To https://folio-org.atlassian.net/wiki/display/DD/Pull+Request+Guidelines |
| Comments |
| Comment by David Crossley [ 22/Jan/21 ] |
|
This is now done and published via pull/682. The main changes were in https://dev.folio.org/guidelines/pull-requests-checklists at Introduction and in the first section. Also expanded existing notes in https://dev.folio.org/guidelines/issue-tracker/#linking and https://dev.folio.org/guidelines/which-forum/#github Also explained that the Jira ticket identifier must have explicit format (upper-case with no spaces). I often see ineffective linking because people do not. Perhaps that should also be emphasised at the wiki page. |
| Comment by David Crossley [ 22/Jan/21 ] |
|
A couple of other observations while i was doing this job: That Wiki page does not link to https://dev.folio.org/guidelines/pull-requests-checklists Also that document is still missing the final section https://dev.folio.org/guidelines/pull-requests-checklists/#frontend-pull-request-checklist (was incomplete in the Gdoc when doing
|
| Comment by Marc Johnson [ 22/Jan/21 ] |
|
David Crossley Thanks
That is because it was written entirely independently. I don't know if FOLIO made a decision about pull request check lists. As I understand it, only a few modules use them, and in the ones I'm involved in at least, they are mostly ignored.
I think that work lost traction due to the poor uptake of pull request check lists |