[FOLIO-2630] Fix lokalise not performing language auto-fill for `en_US` (and other English translations) Created: 02/Jun/20 Updated: 06/Aug/20 Resolved: 06/Aug/20 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | P2 |
| Reporter: | Peter Murray | Assignee: | Peter Murray |
| Resolution: | Done | Votes: | 0 |
| Labels: | i18n | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue links: |
|
||||||||||||||||
| Sprint: | |||||||||||||||||
| Development Team: | Core: Platform | ||||||||||||||||
| Description |
|
Overview: See comments in
Steps to Reproduce:
Expected Results: Actual Results: Additional Information: Interested parties: |
| Comments |
| Comment by Cate Boerema (Inactive) [ 03/Jun/20 ] |
|
Peter Murray does this fix require development work by Core Functional? We have never done anything with lokalise, as far as I know. Do you know what team normally does this work? |
| Comment by Peter Murray [ 04/Jun/20 ] |
|
Reply from Lokalise support:
|
| Comment by Zak Burke [ 11/Jun/20 ] |
|
Peter Murray, this Lokalise issue is specific to en_* locales?!? Any update from Lokalise about if/when this may be resolved? If not soon, we may consider directly copying some en values to en_US in order to see those changes in the Goldenrod releases being prepared this week. |
| Comment by Peter Murray [ 11/Jun/20 ] |
|
Hey Zak. There should be no practical impact for the developers and users of an app for the English languages. On export from Lokalize, the system parameters are set to insert the en.json values if a locale doesn't have a value. This bug would make the en_GB.json harder because the English version is not automatically filled in. Are you seeing cases where en_* locales are not matching the en.json value? |
| Comment by Zak Burke [ 13/Jun/20 ] |
|
Peter Murray, on further review I think I am mistaken. My original understanding of Kyle Felker's comments on
Sorry for the red herring! |
| Comment by Zak Burke [ 13/Jun/20 ] |
|
Peter Murray, nope, sorry, I take it back! The Lokalise PR includes Kyles' changes for all locales except en_* locales. The key he updated already exists in those locale files but was not updated with his changes as it was for other, non-en locales. IOW, the problem is that changes to en.json are not propagating to en_*.json files. |
| Comment by Zak Burke [ 15/Jun/20 ] |
|
Peter Murray, any update from Lokalise here? We've had releases of two different UI modules blocked on this because changes made by a developer to en.json aren't propagating to en_US.json, the locale of folio-snapshot, where POs look to review and close tickets. Since the PO doesn't see the change, the ticket stays open. True it's minor work to just update the en_US.json file manually, but given it's not supposed to work that way there's been back and forth on each ticket (because different devs, different modules, different POs) and it's adding up. |
| Comment by Peter Murray [ 15/Jun/20 ] |
|
No, no update. Crap. I'll apply the work-around suggested in Lokalise's June 4th message, then re-run the pull. |
| Comment by Zak Burke [ 27/Jul/20 ] |
|
Bump. |
| Comment by Peter Murray [ 27/Jul/20 ] |
|
No recent update from Lokalise. I didn't do the manual process when I ran the batch import this morning. I'll do that and re-run. |
| Comment by Peter Murray [ 27/Jul/20 ] |
|
Zak Burke: I just looked and I wonder if the issue is resolved. I don't see any instances where changes to `en.json` were not copied to `en_US.json`. Do you have an example? |
| Comment by Zak Burke [ 27/Jul/20 ] |
|
Aditya matukumalli, any input? Is it possible we simply haven't configured https://github.com/folio-org/ui-erm-comparisons? If so, is there a hole in the documentation for a new-module setup that we need to plug with "Tell Peter about this new module so he can configure Lokalise"? |
| Comment by Aditya matukumalli [ 27/Jul/20 ] |
|
So, I had updated the translations in en.json on Friday but that didnt get pulled into other language files. I then manually updated the en_US today morning but that change got reverted 5 hours ago via translations bot. So, yes maybe "Tell Peter about this new module so he can configure Lokalise" could be the solution but I am not sure. |
| Comment by Peter Murray [ 27/Jul/20 ] |
|
Ah, I see. The addition of the quotation marks was subtle enough that I didn't see it at first. Okay...will update the translations now and send a follow-up to Lokalise support:
|
| Comment by Aditya matukumalli [ 27/Jul/20 ] |
|
Thank you |
| Comment by Peter Murray [ 06/Aug/20 ] |
|
Evidence shows that this has been resolved. Awaiting confirmation from Lokalise tech support. |