[FOLIO-2613] Fix embedded html due to react-intl v4 upgrade Created: 21/May/20 Updated: 03/Jun/20 Resolved: 21/May/20 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | TBD |
| Reporter: | Peter Murray | Assignee: | Peter Murray |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||
| Sprint: | |||||||||||||
| Description |
|
From Zak Burke: As I’m working through release notes for stripes-core, I wanted to call your attention to this PR: https://github.com/folio-org/stripes-core/pull/845. As part of this PR, translation values with embedded HTML-markup containing attributes, e.g. `<span class= {foo}>...` but not `<span>...`, will need to be updated. I can probably get you a list of strings if that would be helpful. markd made those updates to the locale files in that PR, but they’ve already been overwritten (we knew this would happen). What needs to happen to restore those changes? 99% of the changes should be `<span foo="bar">` to `<span>` (insertion of the attributes will now happen in the code) so the updates aren’t tricky. They’re just … necessary. |
| Comments |
| Comment by Peter Murray [ 21/May/20 ] |
|
Affects these keys:
|
| Comment by Peter Murray [ 21/May/20 ] |
|
Manually made changes with branch lokalise_20200521T190141. For https://github.com/folio-org/ui-developer—configuration.loggingDocumentationLink, I ended up deleting the supplied translations because there wasn't a translation for the newly added "the documentation" (in many cases). |
| Comment by Peter Murray [ 21/May/20 ] |
|
Dina: My ability to edit the right-to-left Arabic translations is severely hampered. For the three translation keys in stripes-core listed above, can you search for each key in Lokalise and change the Arabic translation to remove the {{ class=' {className}'}} text in the <span> tag? (See this pull request for an example of what I mean.) A change to Stripes (
|
| Comment by Dina [ 21/May/20 ] |
|
Peter Murray I have already updated the Arabic translations for the listed keys. No issues here. Thanks |