[FOLIO-2508] folio-ansible stripes-build role uses deprecated package2md from stripes-core Created: 11/Mar/20 Updated: 03/Jun/20 |
|
| Status: | Open |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | TBD |
| Reporter: | Wayne Schneider | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | devops, devops-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: | |
| Development Team: | FOLIO DevOps |
| Description |
|
The stripes-build role in folio-ansible uses a node.js script to generate UI module descriptors under some circumstances. The script uses the deprecated package2md utility from stripes-core. It should instead use stripes-cli – or better yet, the package.json template should be updated to match our other yarn platform package.json files, which no longer call a build-module-descriptors.js script at all. |
| Comments |
| Comment by Mike Taylor [ 11/Mar/20 ] |
|
How can you build a FOLIO platform with UI modules if you don't generate module descriptors for the UI modules at all? |
| Comment by Wayne Schneider [ 11/Mar/20 ] |
|
To be more precise: the current practice is to define a script in the package.json file that uses stripes-cli rather than running build-module-descriptors.js directly:
{
"name": "@folio/platform-complete",
"version": "3.2.0",
"license": "Apache-2.0",
"scripts": {
"build": "export NODE_OPTIONS=\"--max-old-space-size=4096 $NODE_OPTIONS\"; stripes build stripes.config.js",
"stripes": "stripes",
"start": "stripes serve stripes.config.js",
"build-module-descriptors": "stripes mod descriptor stripes.config.js --output ./ModuleDescriptors",
"local": "f=stripes.config.js; test -f $f.local && f=$f.local; echo Using config $f; stripes serve $f",
"test": "echo 'No unit tests implemented'",
"test-int": "stripes test nightmare stripes.config.js",
"test-regression": "stripes test nightmare stripes.config.js --run WD/platform-core/checkout/users/inventory/requests/circulation/tenant-settings",
"lint": "eslint test/ui-testing"
},
|
| Comment by Wayne Schneider [ 11/Mar/20 ] |
|
...and, in the case where you are just using modules that have already-generated module descriptors pulled in from the module descriptor registry, you don't need to build the module descriptors. |
| Comment by Mike Taylor [ 11/Mar/20 ] |
|
Ah, nice. |