[FOLIO-2467] Include mod-ncip edge-ncip in testing/snapshot reference environments Created: 24/Feb/20  Updated: 03/Jun/20  Resolved: 16/Mar/20

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: P2
Reporter: David Crossley Assignee: David Crossley
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Blocks
is blocked by MODNCIP-2 move configuration from property file... Closed
is blocked by MODNCIP-3 Add permissionSets to mod-ncip Module... Closed
Sprint: DevOps: sprint 84, DevOps: sprint 83
Story Points: 3
Development Team: FOLIO DevOps

 Description   

These new repositories are now operating with the CI (MDs and artifacts are deployed) and so are ready for this next stage.

https://github.com/folio-org/mod-ncip
https://github.com/folio-org/edge-ncip



 Comments   
Comment by Jakub Skoczen [ 24/Feb/20 ]

Until MODNCIP-2 Closed is resolved we will statically mount the property files provided in /src/resources of mod-ncip for diku. The example on how to mount the properties is folio-ansible/edge-module role.

Comment by Michelle Suranofsky [ 24/Feb/20 ]

moving this comment to https://folio-org.atlassian.net/browse/MODNCIP-2

Comment by David Crossley [ 06/Mar/20 ]

Michelle Suranofsky When MODNCIP-2 Closed is finished, and the mod-ncip master snapshots are meeting the requirements (https://dev.folio.org/guides/install-backend-module/) then we can proceed with this task FOLIO-2467 Closed . Note that this is just one step on the way to getting your module in to the upcoming Quarterly release.

Comment by David Crossley [ 09/Mar/20 ]

The manually-initiated Jenkins folio-testing-test 53 build was successful, and my basic curl script could reach mod-ncip there.

When you are ready with the module permissions work, then i will run that build again.

Comment by David Crossley [ 09/Mar/20 ]

Michelle Suranofsky Is there a set of "NCIP Properties" that would make sense to be included in the reference environments for the "diku" tenant?

If so, then we do have a mechanism with folio-ansible to add them to mod-configuration. Please provide these details.

If not, then i presume that people intending to test via these reference environments would add their relevant settings via mod-configuration and initialise as explained in the mod-ncip README.

It would be useful to add to the README an example usage of mod-configuration (for example see mod-email).

Comment by Michelle Suranofsky [ 09/Mar/20 ]

I'll take a look for diku properties that would make sense for NCIP and let you know.

I'll add mod-configuration usage examples.

Comment by Michelle Suranofsky [ 09/Mar/20 ]

David Crossley What format would you like these settings in (e.g. json file? csv file? script?) thank you!

Comment by David Crossley [ 09/Mar/20 ]

Keep it minimal and simple, as it is just an example.

As explained at https://github.com/folio-org/mod-ncip#required-configurations
the "NCIP Properties" are key-value pairs, so just a text file.

Comment by David Crossley [ 10/Mar/20 ]

Michelle Suranofsky : The next steps. Remember that the module deadline is this Friday (see #releases Slack channel for details and co-ordination).

  • Merge the recent code changes (which includes ModuleDescriptor permissions).
  • Then i can run the folio-testing-test Jenkins build again.
  • Then add it to the testing and snapshot reference environments prior to the daily builds.
  • (The configuration work can follow separately.)
  • Then you can make a release (see release procedures) including adding to "platform-complete".
Comment by David Crossley [ 12/Mar/20 ]

Today i tested and merged the configuration. So mod-ncip is now in the reference environments for folio-testing and folio-snapshot-load and folio-snapshot.

So now you can proceed to verify mod-ncip, and add its configuration via calls to mod-configuration. See the notes at reference environments for how to reach the okapi.

If you merge more changes to mod-ncip master, then they will be available in the daily re-builds tomorrow. Note that they are complete re-builds, so would clear any mod-configuration stuff.

Regarding edge-ncip: It is added to folio-testing and folio-snapshot-load today. However i did need to remove it before the other builds happened. Nothing to do with your work. It was because there is shared configuration with the folio-release environment for all edge-modules. That build broke because there is not yet an actual release of mod-ncip. So you can verify edge-ncip via folio-testing and folio-snapshot-load, but only today.

When you are happy, then the next step is for you to make a release of each. See the notes in the previous comment. As usual, if you need any help then please ask.

Comment by David Crossley [ 16/Mar/20 ]

The mod-ncip and edge-ncip are now in the folio-snapshot and folio-testing.

As a release has now been made for each, then FOLIO-2512 Closed is adding them to platform-complete.

Generated at Thu Feb 08 23:20:51 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.