[FOLIO-2440] integration test must create own policies Created: 16/Jun/19 Updated: 03/Jun/20 Resolved: 04/Feb/20 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | TBD |
| Reporter: | Zak Burke | Assignee: | Zak Burke |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: | Core: F - Sprint 81 |
| Story Points: | 8 |
| Development Team: | Prokopovych |
| Description |
|
The new-request integration test in folio-core uses hard-coded values for many policies without verifying that they exist: priority: t, s, c, b, a, m, g fallback-policy: l one-hour r hold-only n basic-notice-policy m book: l example-loan-policy r allow-all n alternate-notice-policy Instead, it should create its own policies just as the loan-renewal tests do. That policy-creation code can either be copied or factored out into a common location. |
| Comments |
| Comment by Zak Burke [ 30/Jan/20 ] |
|
This ticket started off life in ui-requests, but it's really an app-wide ticket that has new urgency because processes like checkout are getting smarter and more thorough WRT checking circulation rules and this is leading to test failures. For example, checkout will fail if the given overdue-policy or lost-item-policy cannot be found. This means integration tests that manipulate those policies can no longer use dummy values for those policies; they have to do the work of creating them and cleaning them up when finished. It may be possible to extract some of that work to a helper function in stripes-testing. |