[FOLIO-2361] enable mod-audit-filter in platform-complete Created: 20/Nov/19 Updated: 03/Jun/20 Resolved: 21/Nov/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | Jakub Skoczen | Assignee: | John Malconian |
| Resolution: | Done | Votes: | 0 |
| Labels: | platform-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||
| Sprint: | CP: sprint 77 | ||||||||||||||||
| Story Points: | 2 | ||||||||||||||||
| Development Team: | Core: Platform | ||||||||||||||||
| Description |
|
Context in https://folio-org.atlassian.net/browse/UXPROD-1703 The module has been removed in this commit: https://github.com/folio-org/platform-complete/commit/fb030eb8693a0cb94f997613d6334dc32ec12e15 Please verify if performance in folio-test-platform take a dip after enabling these modules. |
| Comments |
| Comment by Jakub Skoczen [ 20/Nov/19 ] |
|
Hongwei Ji any chance you could take a look at this? I'd like to make sure we verify enabling these modules does not have adverse effects on performance. |
| Comment by Hongwei Ji [ 20/Nov/19 ] |
|
Jakub Skoczen mod-audit-filter was changed to use the request-log filter type (added by Adam Dickmeiss so Okapi won't care the filter response), so technically it should not impact the perf. Of course, if audit modules run on the same box as other modules, it might still impact perf but that would be a different reason. |
| Comment by Jakub Skoczen [ 20/Nov/19 ] |
|
Hongwei Ji Perfect, can you please review the perf test resuts when John closes this ticket? |
| Comment by Hongwei Ji [ 20/Nov/19 ] |
|
Jakub Skoczen Sure. |
| Comment by John Malconian [ 20/Nov/19 ] |
|
Attempted to re-add mod-audit/mod-audit-filter to snapshot, but there was an issue with enabling the tenant. Will look at the logs and try again in the morning. |
| Comment by John Malconian [ 21/Nov/19 ] |
|
mod-audit and mod-audit-filter have been added back into platform-complete, including snapshot as well as the master branches Inclusion in the reference builds is scheduled in the next iteration of builds of folio-snapshot and folio-release. |