[FOLIO-2332] Error with login screens of all of today's reference environments: something SVG Created: 30/Oct/19  Updated: 03/Jun/20  Resolved: 30/Oct/19

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P1
Reporter: David Crossley Assignee: Zak Burke
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Blocks
blocks UIIN-798 Include New "Open - Awaiting delivery... Closed
Sprint:

 Description   

With today's daily build of the reference environments, there is a glitch whereby the login screen will not show.

The browser JavaScript console shows something about SVG:

Error: Module build failed (from ./node_modules/react-svg-loader/lib/loader.js):
TypeError: Cannot set property 'multipassCount' of undefined
    at optimizeOnceCallback (/etc/folio/stripes/node_modules/svgo/lib/svgo.js:41:37)
    at /etc/folio/stripes/node_modules/svgo/lib/svgo.js:71:9
    at SAXParser.sax.onend (/etc/folio/stripes/node_modules/svgo/lib/svgo/svg2js.js:169:13)
    at emit (/etc/folio/stripes/node_modules/sax/lib/sax.js:624:35)
    at end (/etc/folio/stripes/node_modules/sax/lib/sax.js:667:5)
    at SAXParser.write (/etc/folio/stripes/node_modules/sax/lib/sax.js:975:14)
    at SAXParser.close (/etc/folio/stripes/node_modules/sax/lib/sax.js:157:38)
    at module.exports (/etc/folio/stripes/node_modules/svgo/lib/svgo/svg2js.js:182:28)
    at SVGO._optimizeOnce (/etc/folio/stripes/node_modules/svgo/lib/svgo.js:63:5)
    at /etc/folio/stripes/node_modules/svgo/lib/svgo.js:56:14
    at new Promise (<anonymous>)
    at SVGO.optimize (/etc/folio/stripes/node_modules/svgo/lib/svgo.js:25:12)
    at /etc/folio/stripes/node_modules/react-svg-core/lib/index.js:23:26


 Comments   
Comment by Yurii Danylenko [ 30/Oct/19 ]

Here is an issue which causes the error https://github.com/svg/svgo/issues/1174

Comment by Zak Burke [ 30/Oct/19 ]

Thanks, Yurii Danylenko! IOW, this is caused by a bug in a third-party library. I'll add a (temporary) resolutions property to the platforms to keep us on an older version.

Comment by Marc Johnson [ 30/Oct/19 ]

Yurii Danylenko

Does that mean that the fix for this is to add a resolution to the platforms to use version 1.3.0 of the svg library until a new version is released?

Scratch that question, Zak Burke already came to that conclusion

Comment by Zak Burke [ 30/Oct/19 ]

svgo just released v1.3.2 so the final resolution is simply to rebuild the reference environments; the new version should be picked up automatically.

Comment by Zak Burke [ 30/Oct/19 ]

The issue was a buggy third-party dependency for which a new release is now available. The "solution" is simply to rebuild the UI bundle now that this release is available.

Generated at Thu Feb 08 23:19:53 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.