[FOLIO-2300] Lokalise not removing keys from database after keys removed from `en.json` Created: 05/Oct/19  Updated: 03/Jun/20  Resolved: 05/Oct/19

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: P2
Reporter: Peter Murray Assignee: Peter Murray
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Sprint:

 Description   

There are at least two keys that are in Lokalise for which the corresponding keys in the GitHub repositories have been deleted. The GitHub repo is https://github.com/folio-org/ui-circulation and we are pulling the `translations/ui-circulation/en.json` file into Lokalise. Clean-up mode is turned on for this repo. The keys that are in Lokalise but not in `en.json` are settings.loanPolicy.fDDSRequired and settings.fDDSform.nameRequired.



 Comments   
Comment by Peter Murray [ 05/Oct/19 ]

From: Dmitry from Lokalise <dmitry@lokalise.co>
Date: Sep 26, 2019, 8:13 AM -0400
To: jester@dltj.org
Subject: Re: There are at least two keys that are in Lokalise for which the corr...

Hello Peter! We have found the cause of the issue.
The person who created this integration is not the project administrator anymore, it blocks some options like cleanup mode.
We can manually fix it if you can provide me with the email address of the user who will became as "Integration creator", so all the functions will work as expected.

Comment by Peter Murray [ 05/Oct/19 ]

On Sep 29, 2019, 12:37 PM -0400, Peter Murray <jester@dltj.org>, wrote:
Oh, wow! That must have been from the project's very early days when István and I were setting things up. We use a dedicated GitHub account now for all webhooks. That account, `folio-translations` uses my work email address ("peter@indexdata.com").

It looks like the first nine GitHub integrations for this project use the incorrect GitHub Personal Access Token. Do you have a way of updating the configuration to use the token from the `folio-translations` account that the rest of the integrations use?

  • folio-org/stripes-core
  • folio-org/stripes-components
  • folio-org/stripes-smart-components
  • folio-org/ui-checkin
  • folio-org/ui-checkout
  • folio-org/ui-circulation
  • folio-org/ui-inventory
  • folio-org/ui-requests
  • folio-org/ui-users

Thank you for your help.

Comment by Peter Murray [ 05/Oct/19 ]

From: Dmitry from Lokalise <dmitry@lokalise.co>
Date: Oct 3, 2019, 2:32 AM -0400
To: jester@dltj.org
Subject: Re: There are at least two keys that are in Lokalise for which the corr...

Hello Peter,

We have fixed this issue.
Note, some of your GitHub handlers do not have integration owners anymore as this user been removed from a team.

In order to fix it you have to remove and add again these handlers:

Please, let me know if any assistance is required.
Otherwise, have a good day.

Comment by Peter Murray [ 05/Oct/19 ]

Ran a `lokalisepush.py` job, then removed `folio-org/ui-checkin` and readded. Then ran the lokalise-push job again, which resulted in a pull request that removed three keys that were no longer in `en.json`. Will removed and readd the remaining 8 integrations that used István personal GitHub personal access token.

Comment by Peter Murray [ 05/Oct/19 ]

Clean-up done in these pull requests:

```
2019-10-05 16:49:27,855 - INFO - makepullrequests@38 - Pull request https://github.com/folio-org/ui-checkin/pull/216 created
2019-10-05 16:50:29,289 - INFO - makepullrequests@38 - Pull request https://github.com/folio-org/ui-eholdings/pull/884 created
2019-10-05 17:25:11,524 - INFO - makepullrequests@38 - Pull request https://github.com/folio-org/ui-users/pull/991 created
2019-10-05 17:26:14,210 - INFO - makepullrequests@38 - Pull request https://github.com/folio-org/stripes-smart-components/pull/631 created
2019-10-05 17:27:15,930 - INFO - makepullrequests@38 - Pull request https://github.com/folio-org/ui-inventory/pull/721 created
2019-10-05 17:29:20,707 - INFO - makepullrequests@38 - Pull request https://github.com/folio-org/stripes-components/pull/1070 created
2019-10-05 17:30:22,516 - INFO - makepullrequests@38 - Pull request https://github.com/folio-org/ui-circulation/pull/446 created
```

Now closing.

Generated at Thu Feb 08 23:19:39 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.