[FOLIO-2300] Lokalise not removing keys from database after keys removed from `en.json` Created: 05/Oct/19 Updated: 03/Jun/20 Resolved: 05/Oct/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P2 |
| Reporter: | Peter Murray | Assignee: | Peter Murray |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: |
| Description |
|
There are at least two keys that are in Lokalise for which the corresponding keys in the GitHub repositories have been deleted. The GitHub repo is https://github.com/folio-org/ui-circulation and we are pulling the `translations/ui-circulation/en.json` file into Lokalise. Clean-up mode is turned on for this repo. The keys that are in Lokalise but not in `en.json` are settings.loanPolicy.fDDSRequired and settings.fDDSform.nameRequired. |
| Comments |
| Comment by Peter Murray [ 05/Oct/19 ] |
|
From: Dmitry from Lokalise <dmitry@lokalise.co> Hello Peter! We have found the cause of the issue. |
| Comment by Peter Murray [ 05/Oct/19 ] |
|
On Sep 29, 2019, 12:37 PM -0400, Peter Murray <jester@dltj.org>, wrote: It looks like the first nine GitHub integrations for this project use the incorrect GitHub Personal Access Token. Do you have a way of updating the configuration to use the token from the `folio-translations` account that the rest of the integrations use?
Thank you for your help. |
| Comment by Peter Murray [ 05/Oct/19 ] |
|
From: Dmitry from Lokalise <dmitry@lokalise.co> Hello Peter, We have fixed this issue. In order to fix it you have to remove and add again these handlers: Please, let me know if any assistance is required. |
| Comment by Peter Murray [ 05/Oct/19 ] |
|
Ran a `lokalisepush.py` job, then removed `folio-org/ui-checkin` and readded. Then ran the lokalise-push job again, which resulted in a pull request that removed three keys that were no longer in `en.json`. Will removed and readd the remaining 8 integrations that used István personal GitHub personal access token. |
| Comment by Peter Murray [ 05/Oct/19 ] |
|
Clean-up done in these pull requests: ``` Now closing. |