[FOLIO-2208] Create code owners group for circulation and inventory backend modules Created: 07/Aug/19 Updated: 03/Jun/20 Resolved: 16/Aug/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | TBD |
| Reporter: | Marc Johnson | Assignee: | David Crossley |
| Resolution: | Done | Votes: | 0 |
| Labels: | platform-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
| Sprint: | CP: sprint 70 |
| Story Points: | 2 |
| Development Team: | Core: Platform |
| Description |
|
In order to allow for easier management of code owners for repositories, we could introduce github teams to represent the code owners. The circulation and inventory modules already have code owners files, for example Therefore we need to:
Circulation backend code ownersModules
Members (team, github username in brackets)
Inventory backend code ownersModules
Members (team, github username in brackets)
|
| Comments |
| Comment by David Crossley [ 13/Aug/19 ] |
|
All done. |
| Comment by Marc Johnson [ 13/Aug/19 ] |
|
Jakub Skoczen Kostyantyn Khodarev David Crossley Let me know I missed Oleh Pochernin from the circulation code owners list. I think we should add him in, any reasons why we shouldn’t? (He was in the list previously for circulation storage). |
| Comment by Marc Johnson [ 14/Aug/19 ] |
|
This pull request shows a comment that a review was requested from the code owners team
However, the team does not show up in the reviewers section on the right hand side, do you know why? |
| Comment by David Crossley [ 15/Aug/19 ] |
|
I conducted a test: Temporarily adjusted repo Settings for: Then did this pull/312 and now the group as a whole does show in the "Reviewers" panel. See attached screenshot require-reviewers.png |
| Comment by David Crossley [ 16/Aug/19 ] |
|
These codeowners groups are added. Closed this ticket. The topic about when to add the branch protection can be handled separately when ready. |