[FOLIO-2165] Create correct builds for both snapshot and testing environments Created: 12/Jul/19 Updated: 03/Jun/20 Resolved: 12/Jul/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | P2 |
| Reporter: | Michal Kuklis | Assignee: | John Malconian |
| Resolution: | Done | Votes: | 0 |
| Labels: | platform-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||
| Sprint: | |||||||||||||||||||||||||
| Description |
|
It looks like both folio-snapshot and folio-testing are misconfigured currently. I see these errors in the console: You are currently using minified code outside of NODE_ENV === 'production'. This means that you are running a slower development build of Redux. You can use loose-envify (https://github.com/zertosh/loose-envify) for browserify or DefinePlugin for webpack (http://stackoverflow.com/questions/30030031) to ensure you have the correct code for your production build. and React-Hot-Loader: misconfiguration detected, using production version in non-production environment. It would be great to fix these and make sure folio-snapshot runs in production mode. |
| Comments |
| Comment by Marc Johnson [ 12/Jul/19 ] |
|
Jakub Skoczen John Malconian Ian Hardy Wayne Schneider In order to get a clearer understanding of the recent UI performance changes, we need to make this change to remove the noise / degradation caused by non-production configuration Could there be capacity to expedite this within the core platform team? |
| Comment by John Malconian [ 12/Jul/19 ] |
|
Marc Johnson - I'll work on this today. |
| Comment by Marc Johnson [ 12/Jul/19 ] |
|
John Malconian thanks, much appreciated |
| Comment by John Malconian [ 12/Jul/19 ] |
|
The next folio-snapshot and folio-snapshot-core builds set NODE_ENV=production. Test instance here: https://folio-snapshot-test.aws.indexdata.com/ |