[FOLIO-2099] BigTest: counterintuitive behavior using isPresent Created: 12/Jun/19 Updated: 08/Dec/21 Resolved: 08/Dec/21 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | TBD |
| Reporter: | Matt Connolly | Assignee: | Anton Emelianov (Inactive) |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | bigtest | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: |
| Description |
|
We discovered that tests written using the isPresent property can "fail" (i.e., not behave as expected) in counterintuitive ways. A test written in the form expect([interactor].[selector].isPresent).to.be.[boolean] (example) will pass whether the boolean comparator is true or false. Upon reflection, this is presumably because of the way that convergences behave: while waiting for a component to appear in the DOM, isPresent will return false, and thus a false comparison will pass. If the component does appear before the timeout, then a true comparison will also pass. Thus this probably is not an actual bug, but it would probably be a good idea to clarify and emphasize this behavior in the documentation. If a developer doesn't fully understand what's going on with the convergences, it's very easy to write meaningless tests using isPresent. |
| Comments |
| Comment by Cate Boerema (Inactive) [ 18/May/20 ] |
|
Anton Emelianov can we tag this with something to get it out of our general bug statistics? Or maybe you should just exclude all issues with the bigtest tag from the general stats (like you do with the ci/cd stuff) |
| Comment by Anton Emelianov (Inactive) [ 18/May/20 ] |
|
Cate Boerema, I found 5 bugs with 'bigtest' label. I added this label to the exclusion list. |
| Comment by Ann-Marie Breaux (Inactive) [ 30/Nov/21 ] |
|
Hi Anton Emelianov Which team should be assigned to this? It seems like it should move to the FAT project, and be assigned to a dev team. Could you review it? Thank you! |
| Comment by Anton Emelianov (Inactive) [ 08/Dec/21 ] |
|
We are migrating away from BTOG and hence will not put effort into resolving this issue or others like it. |