[FOLIO-2059] folio-reference environments only show Users and Settings Created: 01/Jun/19 Updated: 03/Jun/20 Resolved: 02/Jun/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | P1 |
| Reporter: | Ann-Marie Breaux (Inactive) | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | platform-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
| Sprint: | CP: ready for planning |
| Development Team: | Core: Platform |
| Description |
|
Overview: folio-testing, folio-snapshot, and folio-snapshot-load only show the Users and Settings/Users apps, nothing else Steps to Reproduce:
Expected Results: All apps should show in the bar or the dropdown Actual Results: Only the Users and Settings/Users apps show Additional Information: See attached screenshots |
| Comments |
| Comment by Ian Hardy [ 01/Jun/19 ] |
|
Not 100% sure why yet, but observed that downgrading from stripes-core 3.6.1000562 to stripes-core 3.6.1000561 in platform-complete#snapshot clears this up in local builds. Relevant changes between the two versions are described in https://folio-org.atlassian.net/browse/STCOR-148 and https://github.com/folio-org/stripes-core/pull/684. Can replicate by building platform-complete#snapshot with the change to yarn.lock in the attached diff. . |
| Comment by Ann-Marie Breaux (Inactive) [ 01/Jun/19 ] |
|
Thank you so much for looking at it Ian Hardy. I'm guessing I'm not the only one trying to check and close tickets this weekend! |
| Comment by Jason Skomorowski [ 01/Jun/19 ] |
|
sigh apologies, I should have listened to the sense of forboding that accompanies a Friday afternoon merge. I'll take a look. |
| Comment by Jason Skomorowski [ 01/Jun/19 ] |
|
Found the immediate issue, addressed it and added a test to help better guard against that in future, went for supper while the PR was being processed by CI. It's merged now so we'll see if that was the only problem once folio-testing is regenerated (I forget, is that hourly?) |
| Comment by David Crossley [ 02/Jun/19 ] |
|
Beaut. Frontend every two hours https://dev.folio.org/guides/automation/#reference-environments |
| Comment by David Crossley [ 02/Jun/19 ] |
|
After today's automated builds, the reference environments are now happy. |
| Comment by Ann-Marie Breaux (Inactive) [ 03/Jun/19 ] |
|
Thank you very much David Crossley, Ian Hardy and Jason Skomorowski - back to story checking! |
| Comment by Viktor Soroka [ 03/Jun/19 ] |
|
Hello guys, not sure whether it is related but I found the issue when the links get duplicated in settings. Maybe it is somehow connected. |
| Comment by Jason Skomorowski [ 03/Jun/19 ] |
|
It sounds like it may well be related, thanks! I'll take a look. |
| Comment by Jason Skomorowski [ 03/Jun/19 ] |
|
Ah, I didn't expect the case of modules of type 'settings' also redundantly using 'hasSettings: true'. I've pushed a fix. |