[FOLIO-2023] Change default edge-api port on Vagrant box from 8000 to 8130 Created: 17/May/19 Updated: 03/Jun/20 Resolved: 31/May/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | Hongwei Ji | Assignee: | Ian Hardy |
| Resolution: | Done | Votes: | 0 |
| Labels: | platform-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: | CP: sprint 64 |
| Story Points: | 0.5 |
| Development Team: | Core: Platform |
| Description |
|
Current edge-api port 8000 on Vagrant box is too common and is easily to conflict. Chatted with Wayne Schneider and decide to change to 8130. It is easier to remember due to the similarity to Okapi 9130. |
| Comments |
| Comment by Ian Hardy [ 29/May/19 ] |
|
This looks fine to me, opened up a corresponding pr on folio-infrastructure. Craig McNally Kruthi Vuppala anything you'd need to update when this happens? |
| Comment by Hongwei Ji [ 29/May/19 ] |
|
Ian Hardy, I have kept our EBSCO team in the loop about this proposed change. There should not been any impact to us except using Vagrant for local development. |
| Comment by Ian Hardy [ 29/May/19 ] |
|
Ok, I misunderstood. The playbooks and group variables for say snapshot are shared by the packer job that creates the vagrant box and the job to build the snapshot reference environment. Disentangling them is actually a bit tricky, but we could do it I suppose. Before we do that though, anything wrong with just updating the port mappings in the Vagrantfile to map 8000 on the guest to 8130 on the host? testing_backend.vm.network "forwarded_port", guest: 8000, host: 8130 |
| Comment by Hongwei Ji [ 29/May/19 ] |
|
That should do it. Good thought Ian Hardy! |
| Comment by Wayne Schneider [ 29/May/19 ] |
|
Ian Hardy that will require an update to the Vagrantfiles in folio-infrastructure, let me know if you need more of a pointer. |
| Comment by Craig McNally [ 29/May/19 ] |
|
Ian Hardy please update https://folio-org.atlassian.net/wiki/display/FOLIOtips/Edge+APIs with the new ports once the change is made. There are some configuration changes we'll need to make on the GOBI end (test account), but it's pretty minor. |
| Comment by Ian Hardy [ 29/May/19 ] |
|
Craig McNally I misunderstood when I mentioned you in an earlier comment, this will be for Vagrant boxes only (no changes to hosted reference envs). |
| Comment by John Malconian [ 30/May/19 ] |
|
Ian Hardy for the hosted folio instances, to update the port on the elb, change the port in the the 'folio-elb' ansible role in folio-infrastructure on master. If we want to change it for the folio-bellis (q1 release) builds as well, then do the same on the q1-2019-release branch. |