Allow for the creation and management of organization records (UXPROD-1139)

[FOLIO-1957] Include mod-organizations-storage and ui-organizations into testing/snapshot environments Created: 10/Apr/19  Updated: 03/Jun/20  Resolved: 17/Apr/19

Status: Closed
Project: FOLIO
Components: Continuous Integration
Affects versions: None
Fix versions: None
Parent: Allow for the creation and management of organization records

Type: Story Priority: P2
Reporter: Mikita Siadykh Assignee: Ian Hardy
Resolution: Done Votes: 0
Labels: acquisitions, ci, organizations, platform-backlog
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File vendorsmenu.png    
Issue links:
Blocks
blocks UIORGS-24 Remove '+' from translation strings Closed
blocks UIORGS-2 Restructure "view details" screen for... Closed
blocks UIORGS-22 Vendor view pane: Contact person area... Closed
blocks UIORGS-31 App UI changes related to Vendor pivot Closed
blocks UIORGS-32 Settings UI changes related to Vendor... Closed
Relates
relates to FOLIO-1938 Create organizations github repositor... Closed
Sprint: Core: Platform - Sprint 61
Story Points: 3
Development Team: Core: Platform
Epic Link: Allow for the creation and management of organization records

 Description   

Overview:
in FOLIO-1938 Closed mod-organizations-storage and ui-organizations were created and we'd like to have them on testing/snapshot environments to allow e2e testing

Acceptance Criteria:
new modules are available on testing/snapshot environments and can be reach by PO for e2e testing



 Comments   
Comment by Ian Hardy [ 11/Apr/19 ]

Some issues to consider here.

1. Interface name changes

In addition to ui-organizations there are some other modules that requre vendor-storage.* interfaces:

  • mod-erm-usage
  • mod-gobi
  • mod-orders
  • ui-orders

We'd either need to run both mod-vendors-storage and mod-organizations-storage at the same time or do some coordination.

2. Singular plural agreement
Interface and permissions names in mod-organizations are all plural but the handler paths are all singular. Would it make sense to have them agree as they do in mod-vendors?

in mod vendors:
interface vendor-storage.addresses has the handler /vendor-storage/addresses which requires vendor-storage.addresses.collection.get

in mod-organizations this looks like:
interface organizations-storage.addresses has the handler /organization-storage/addresses which requires organizations-storage.addresses.collection.get

Comment by Piotr Kalashuk [ 12/Apr/19 ]

The plan is to have vendors and organizations modules included to testing/snapshot environments until organizations are fully stabilized and integrated with orders app. After it is done, the organizations modules will be officially released and all vendors modules can be retired fully and excluded from all the environments. We are planning to create separate ticket for that.

Modules' names are based on Naming conventions:

...
Most module names will be in the plural sense, e.g. mod-notes, especially when responsible for collections of items.
...
The first portion is the exact name of the responsible module (back-end modules drop the mod- prefix).
...
The name of an interface (its id) uses dash-separated strings. It is normally the same as the set of pathPatterns for which it provides handlers.

The endpoint path's are based on Acquisitions API Listing and now they are also in plural there. We will change endpoints in ramls and module descriptor today.
UPDATE:

interface organizations-storage.addresses has the handler /organization-storage/addresses which requires organizations-storage.addresses.collection.get

The endpoints (and handlers) have been updated to avoid any confusions...

Comment by Ian Hardy [ 15/Apr/19 ]

Thanks for those updates Piotr. I just did a test build and it looks good. Do you want to update the application name in the applications and settings menus before integrating? I don't think it causes any problems but it looks a little confusing when both vendors and organizations are installed.

Comment by Mikita Siadykh [ 15/Apr/19 ]

hi Ian Hardy

actually name has been updated previous week + links, perhaps you have old code base

or it can be issue with translation, so please proceed with integration and we will fix the rest tomorrow

Comment by Ian Hardy [ 16/Apr/19 ]

This up in folio-testing now and will go into snapshot with tonight's build. Its running @folio/organizations 1.0.100012 and still showing up as "Vendors" in the the Apps and settings menus. UIORGS-31 Closed and UIORGS-32 Closed address the naming issue.

Comment by Craig McNally [ 16/Apr/19 ]

Piotr Kalashuk Sorry about the earlier incorrect paths in the Acquisitions API Listing. I had updated the document last week after seeing Ian's comment in MODORGSTOR-4 Closed but forgot to leave a comment saying I did so.

Generated at Thu Feb 08 23:17:09 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.