[FOLIO-1898] Open PRs in platform-core do not include latest commits from branch Created: 22/Mar/19  Updated: 03/Jun/20  Resolved: 26/Mar/19

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: P3
Reporter: John Malconian Assignee: John Malconian
Resolution: Done Votes: 0
Labels: ci, platform-backlog
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Sprint:
Development Team: Core: Platform

 Description   

The following behavior is observed when a PR is open for branch X in platform-core and a
new developer commit is made to branch X.

1. if a git commit to update the install json files or the yarn.lock is made during the
branch build by Jenkins, the open PR build that is simultaneously triggered will not use the new install json and yarn lock files committed during the branch build because they haven't been committed yet. It will, instead, use the previous versions.

2. The next problem is that a subsequent PR build will be triggered because of the commits made in branch X. This build detects that the last git commit was a CI commit and exits gracefully as designed to avoid build loops. The result is that a PR build based on the latest changes in branch X is never triggered.

In order to trigger another PR build with the latest versions of the install json and yarn lock
file, a trivial commit needs to be made to the branch.



 Comments   
Comment by John Malconian [ 22/Mar/19 ]

Wayne SchneiderAdam DickmeissDavid CrossleyIan HardyJakub Skoczen - I'm soliciting ideas on how I can solve this problem. Any ideas are welcome.

Comment by John Malconian [ 26/Mar/19 ]

I think I have a satisfactory solution f by committing new install json and yarn lock file to the change branch during the PR build instead of the branch build. Not optimal but better for now.

Generated at Thu Feb 08 23:16:42 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.