[FOLIO-1883] New git repo "edge-sip2" Created: 20/Mar/19 Updated: 15/Jun/20 Resolved: 15/Jun/20 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | Matt Reno | Assignee: | David Crossley |
| Resolution: | Done | Votes: | 0 |
| Labels: | platform-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: | |
| Development Team: | Core: Platform |
| Description |
|
We are beginning to work on SIP2 integration with FOLIO. The following repo has been created: https://github.com/folio-org/edge-sip2 The repo will likely need to be setup for CI/CD usage. The only thing I did was restrict write access to the repo and remove the issues/wiki tabs. |
| Comments |
| Comment by Matt Reno [ 20/Mar/19 ] |
|
SonarCloud needs setup as well. The edge-sip2 Jenkins build is failing because there is no edge-sip2 project in sonar. |
| Comment by David Crossley [ 21/Mar/19 ] |
|
Added the Dockerhub spaces. I merged your pull/1 and that enabled the initial baseline Sonar scan. Now that the initial stuff is happening, i also configured master branch protection in GitHub. |
| Comment by David Crossley [ 21/Mar/19 ] |
|
Matt Reno in the Dockerfile, consider using "EXPOSE 8081". See discussion in
Also the "docker" directory and hence "docker/docker-entrypoint.sh" are not needed now. The jenkins-pipeline-libs provides that. |
| Comment by Matt Reno [ 21/Mar/19 ] |
|
Thanks David Crossley. I couldn't remember if we needed the docker directory. I thought we didn't but so many projects still had it, so I added it. I'll clean it up. As far as the port goes, the SIP2 protocol is not HTTP based, so it is not clear which port we need to use. The 6443 port is the port the Alma uses for SIP2 SSL tunneling. I'll keep it in mind, though I'm not sure if 8081 is appropriate here... I don't know what is. Those details are TBD, at least until we talk more with Chalmers. |