[FOLIO-1831] Enforce 1 mandatory PR approval before allowing merge for acquisitions repos Created: 27/Feb/19 Updated: 03/Jun/20 Resolved: 28/Feb/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | Continuous Integration |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Story | Priority: | P3 |
| Reporter: | Craig McNally | Assignee: | David Crossley |
| Resolution: | Done | Votes: | 0 |
| Labels: | ci, platform-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||
| Sprint: | Core: Platform - Sprint 58 | ||||||||
| Story Points: | 1 | ||||||||
| Development Team: | Core: Platform | ||||||||
| Description |
|
Please adjust github settings for the following repositories so that a minimum of 1 PR approval is required before allowing a PR merge. If possible, please disallow self-approval of PRs
|
| Comments |
| Comment by David Crossley [ 28/Feb/19 ] |
|
Done all of those repositories. However, i presume that you intended "mod-finance-storage" (and i have done that one). The "mod-finance" is still only partially setup. Yes, people cannot merge their own PRs (until there is an approval). That is implicit. |
| Comment by David Crossley [ 28/Feb/19 ] |
|
There is an option that i did not enable (it is disabled by default):
|
| Comment by Craig McNally [ 28/Feb/19 ] |
|
Great, thanks David Crossley! I appreciate you taking the initiative and using common sense wrt mod-finance(-storage). For now let's leave the stale PR approvals setting as-is. |
| Comment by David Crossley [ 09/Aug/19 ] |
|
Now that mod-finance repository has been re-established, enabled its "1 mandatory PR approval" same as the others. |