[FOLIO-1801] Create invoicing github repositories and add to CI Created: 11/Feb/19  Updated: 03/Jun/20  Resolved: 18/Jun/19

Status: Closed
Project: FOLIO
Components: Continuous Integration
Affects versions: None
Fix versions: None

Type: Story Priority: P2
Reporter: Craig McNally Assignee: David Crossley
Resolution: Done Votes: 0
Labels: acquisitions, ci, invoices, platform-backlog
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Relates
relates to FOLIO-1831 Enforce 1 mandatory PR approval befor... Closed
relates to FOLIO-1865 Add invoicing modules to testing/snap... Closed
relates to FOLIO-1876 include mod-invoice and ui-invoice in... Closed
relates to MODINVOICE-16 Project Setup Closed
relates to MODINVOSTO-1 Project Setup Closed
relates to UINV-1 Project Setup Closed
relates to UXPROD-720 Allow user to create Invoice Closed
Sprint: CP: sprint 66, Core: Platform - Sprint 58
Story Points: 1
Development Team: Core: Platform

 Description   

Overview:
Please create the following github repositories and associated CI infrastructure (Jenkins/Sonarqube/etc.):

Acceptance Criteria:

  • The three repos are created and added to the respective teams
  • Members of those teams can create and merge branches
  • CI has been setup for the repositories, including jenkins builds and sonarqube analysis


 Comments   
Comment by John Malconian [ 12/Feb/19 ]

I went ahead and created and configured the repos above in github. You'll (David Crossley) want to make initial commit to master, get the Docker stuff in place, and configure the API documentation before we commit a Jenkinsfile.

Comment by David Crossley [ 13/Feb/19 ]

Done the initial commit.

Added DockerHub spaces for mod-*.

Added basic Jenkinsfile for each, which will obviously fail until the source code is added.

For the mod-* the runLintRamlCop and publishAPI will operate without configuration. So enable them in Jenkinsfile when their "ramls" directory is added. We can followup with configuration later.

Configured the GitHub Teams for each, plus other initial settings.

As you know there is further guidance at https://dev.folio.org/guidelines/create-new-repo/

Comment by Piotr Kalashuk [ 21/Feb/19 ]

Hi David Crossley,

Could you please advise what is next step to merge PR's prepared for MODINVOICE-16 Closed and MODINVOSTO-1 Closed ?

The pr-merge check is required to be successful to merge the PR to master. But this check fails for both PR's:

Project was never analyzed. A regular analysis is required before analyzing a pull request

I've checked that neither of invoice repositories are yet available in https://sonarcloud.io/organizations/folio-org/projects. As far as I can see the only option available for us is to request SonarCloud installation so I've requested this via https://sonarcloud.io/projects/create interface.

Comment by David Crossley [ 21/Feb/19 ]

I temporarily disabled the pr-merge requirement and merged.

Comment by Piotr Kalashuk [ 21/Feb/19 ]

Thank you!
Both mod-invoice and mod-invoice-storage repositories are now available in sonarcloud and green in Jenkins.

Comment by David Crossley [ 21/Feb/19 ]

So i reckon that your SonarCloud request was not needed.

Comment by David Crossley [ 21/Feb/19 ]

As said above, the ramls stuff can be enable in Jenkinsfile when you are ready. I will follow up with their actual configuration on my tomorrow.

Comment by Piotr Kalashuk [ 21/Feb/19 ]

Looks like yes. Once the changes are in master, "a regular analysis" is being done automatically... But similar situation might be with ui-invoice repository.
Once we start working on code changes, we will be updating Jenkins file accordingly enabling required steps.

Comment by David Crossley [ 28/Feb/19 ]

I cannot finish the initial setup of the ui-invoice repository until at least some basic code is added. So i am marking this issue as a blocker to finishing FOLIO-1831 Closed for ui-invoice.

Comment by David Crossley [ 28/Feb/19 ]

Actually the branch protection and status checks can be enabled for ui-invoice (which is now done) and then can be temporarily disabled to finalise the setup.

Comment by David Crossley [ 18/Jun/19 ]

The ui-invoice has recently been established.

So re-verified the state of setup of all three "invoice" repositories.

Closed this ticket as Done.

Generated at Thu Feb 08 23:16:00 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.