[FOLIO-1757] Add a test case for instance identifier search Created: 30/Jan/19  Updated: 03/Jun/20  Resolved: 05/Feb/19

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: P3
Reporter: Jakub Skoczen Assignee: Hongwei Ji
Resolution: Done Votes: 0
Labels: platform-backlog, q1-performance
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Blocks
blocks MODINVSTOR-182 analyze and optimize identifiers arra... Closed
Relates
relates to MODINVSTOR-266 Fix identifier search slowness due to... Closed
relates to RMB-330 Gin index lost lower and f_unaccent f... Closed
relates to FOLIO-1771 clean up and isolate tests Closed
Sprint: Core: Platform - Sprint 56
Story Points: 2
Development Team: Core: Platform

 Description   

Add the following requests to the performance benchmarks:

limit: 30
query: identifiers == "*\"value\": \"40*\", \"identifierTypeId\": \"8261054f-be78-422d-bd51-4ed9f33c3422\"*" sortby title

URL encoded:

/inventory/instances?limit=30&query=identifiers%20%3D%3D%20%22%2A%5C%22value%5C%22%3A%20%5C%2240%2A%5C%22%2C%20%5C%22identifierTypeId%5C%22%3A%20%5C%228261054f-be78-422d-bd51-4ed9f33c3422%5C%22%2A%22%20sortby%20title

and

limit: 30
query: (identifiers adj "\"value\": \"40*\"") sortby title

URL encoded:

/inventory/instances?limit=30&query=%28identifiers%20adj%20%22%5C%22value%5C%22%3A%20%5C%2240%2A%5C%22%22%29%20sortby%20title


 Comments   
Comment by Jakub Skoczen [ 31/Jan/19 ]

Hongwei Ji Adam Dickmeiss We discussed with Adam that with the UX changes to ui-inventory it is fairly unlikely that the users will search for so short and truncated identifiers. Could you please change both those tests to search for an actual identifier that is in the database?

Comment by Hongwei Ji [ 31/Jan/19 ]

sure Jakub Skoczen

Comment by Hongwei Ji [ 04/Feb/19 ]

Done. In daily perf report, search for 1) FOLIO-1757 Closed search instance by identifier type and value 2)
FOLIO-1757 Closed search instance by identifier value only
For example: https://jenkins-aws.indexdata.com/job/Automation/job/folio-perf-test/220/performance/

Comment by Jakub Skoczen [ 04/Feb/19 ]

Adam Dickmeiss Hongwei Ji The results look really bad, we need to investigate why. Hongwei Ji can you please help Adam run the test case locally to try to reproduce?

Comment by Hongwei Ji [ 04/Feb/19 ]

The specific JMeter test case is https://github.com/folio-org/folio-perf-test/tree/master/Folio-Test-Plans/core-platform/FOLIO-1757; For the test data, you can use the nightly perf data set. On the other hand, my guess is that if you ingest large volume of instance data (~3 million for example) to your local PostgreSQL instance and then run a single query using Postman, you should see the performance issue.

Generated at Thu Feb 08 23:15:41 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.