[FOLIO-1755] verify dependency resolution checking Created: 30/Jan/19  Updated: 03/Jun/20  Resolved: 06/Feb/19

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P3
Reporter: Adam Dickmeiss Assignee: Ian Hardy
Resolution: Done Votes: 0
Labels: ci, core, platform-backlog
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: Text File post.txt    
Issue links:
Blocks
blocks FOLIO-1631 add a "released dependency check" to ... Closed
is blocked by OKAPI-697 POST md check=true too strict Closed
Relates
relates to FOLIO-1577 Automated builds for FOLIO 'release' Closed
relates to OKAPI-683 Allow checking if uploaded Module Des... Closed
relates to OKAPI-696 Post Module: npmSnapshot flag Closed
relates to FOLIO-1753 Replace mod-kb-ebsco with mod-kb-ebsc... Closed
Sprint: Core: Platform - Sprint 56
Story Points: 0.5
Development Team: Core: Platform

 Description   

Problem

When posting a new release of mod-kb-ebsco-java to the registry where only releases of modules are considered in the dependency check. This gives numerous errors. See attached post.txt.

Interface problems:

  • login: folio_users-2.20.0 needs login 4.7. But login 4.7 is not provided by a released module. login 4.7 is provided by mod-login-4.7.1-SNAPSHOT.41.
  • inventory: folio_instances-1.0.10009 needs 2.1. But inventory 2.,1 is provided by mod-inventory-5.1.2-SNAPSHOT.47 and a few other snapshots. There are numerous of folio_instances problems.. They are considered releases, but are really NPM snapshots.. So should we OMIT this module in the check entirely? We already have an npmSnapshot flag for display of modules.. We could have that too for posting.
  • inventory: mod-rtac-1.0.1 interface inventory. Need 5.3. Have 6.1.

The problem is related to the bug in Okapi: Okapi-697.

Task

When Okapi-697 is resolved update the local installation of FOLIO to the Okapi version that includes the fix, pull the MD from folio-registry and perform an upload of mod-kb-ebsco-java ModuleDescriptor to verify that the dependency problem is gone.



 Comments   
Comment by Adam Dickmeiss [ 30/Jan/19 ]

I think we should lax the dependency and only consider dependencies on immediate require list of the module being posted. OKAPI-697 Closed

Comment by Adam Dickmeiss [ 04/Feb/19 ]

Did you have a chance to look into this?

Comment by John Malconian [ 04/Feb/19 ]

Adam Dickmeiss Still on my TODO.

Comment by Ian Hardy [ 06/Feb/19 ]

Verified dependency checking. Using a local instance of Okapi 2.41, pulled module descriptors from the folio registry. posted mod-kb-ebsco to local Okapi with preRelease=false w/o dependency errors. Also tried setting un-meetable requirements in a few MDs files to trigger a dependency error when preRelease is set to false.

folio_users-2.20.0 will still fail if preRelease is false since login 4.7 is not provided by a released module as noted above.

Generated at Thu Feb 08 23:15:40 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.