[FOLIO-1745] folio-testing down and snapshot not updated due to update to mod-vendors interfaces Created: 26/Jan/19 Updated: 03/Jun/20 Resolved: 29/Jan/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | P2 |
| Reporter: | Wayne Schneider | Assignee: | Wayne Schneider |
| Resolution: | Done | Votes: | 0 |
| Labels: | ci, platform-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||
| Sprint: | Core: Platform - Sprint 56 | ||||||||||||||||
| Story Points: | 2 | ||||||||||||||||
| Development Team: | Core: Platform | ||||||||||||||||
| Description |
|
The folio-testing environments (Vagrant and AWS) failed to build overnight 25-26 January due to a major overhaul of the interfaces provided by mod-vendors (https://github.com/folio-org/mod-vendors/pull/43), which caused sample data loading to fail. Resolution will be multi-part:
|
| Comments |
| Comment by Wayne Schneider [ 26/Jan/19 ] |
|
mod-gobi is also incompatible with the new mod-vendors, so it will be omitted from the folio-testing CI builds until that is resolved (
|
| Comment by Wayne Schneider [ 26/Jan/19 ] |
|
As of 26 Jan 13:00 ET, folio-testing is back up. There is no vendor sample data, and mod-gobi is also not installed. Stripes reports that both ui-orders and ui-vendors have a missing required interface (`vendor 1.0`), as expected. |
| Comment by Wayne Schneider [ 26/Jan/19 ] |
|
John Komick suggests rolling back the PR in mod-vendors until issues can be resolved in dependent modules. Will discuss further on Monday. |
| Comment by Wayne Schneider [ 28/Jan/19 ] |
|
Updates have been made in ui-orders and ui-vendors, to use the new interfaces, but the okapiInterfaces requirements in the package.json file has not yet been updated. That means that on folio-snapshot, the older mod-vendors will still be pulled in (and presumably ui-orders and ui-vendors will not work). mod-gobi has not been updated at all, AFAIK. John Komick requested that the new sample data be loaded into folio-testing ASAP. After this change, we'll have the following situation: folio-testing: head of master for mod-vendors, ui-orders, ui-vendors. New sample data loaded using the new APIs provided by mod-vendors. No mod-gobi. folio-snapshot: mod-vendors-1.1.0-SNAPSHOT.33 (the last version of mod-vendors that provides the vendor 1.0 interface). Head of master for ui-orders, ui-vendors, mod-gobi. ui-orders and ui-vendors will presumably not work (because they require the old interface in package.json but use the new one). Old sample data loaded using the old API. |
| Comment by Marc Johnson [ 29/Jan/19 ] |
|
Wayne Schneider It appears a version of mod-vendors (mod-vendors-1.1.0-SNAPSHOT.36) which fails to load sample records has made it to folio-snapshot. Each of the sample records fail with an error like below.
failed: [10.36.1.252] (item=/tmp/ansible.cyTCrZ/mod-vendors/sample-data/vendors/naxo.json) => {"changed": false, "connection": "close", "content": "No suitable module found for path /vendor", "content_length": "41", "content_type": "text/plain", "data_file": "/tmp/ansible.cyTCrZ/mod-vendors/sample-data/vendors/naxo.json", "msg": "Status code was 404 and not [201, 422]: HTTP Error 404: Not Found", "redirected": false, "status": 404, "url": "http://folio-snapshot-552.aws.indexdata.com:9130/vendor"}
I was expecting the environment to be unavailable, however that appears to not be the case. Do you know why? Does it not update DNS if the build fails (the current system is pointing to the 551 backend)? |
| Comment by Wayne Schneider [ 29/Jan/19 ] |
|
Thanks for the update, Marc Johnson. ui-orders and ui-vendors now require the new interface provided by mod-vendors, so this should be a relatively easy fix. You're correct, the DNS is not updated unless there is a successful build. |
| Comment by Marc Johnson [ 29/Jan/19 ] |
Did that happen before or after the overnight build? In order for the new versions to be included, and therefore break the load, I imagine this happened before? |
| Comment by Wayne Schneider [ 29/Jan/19 ] |
|
folio-testing and folio-snapshot have both been updated with the newest versions of mod-vendors, ui-orders, and ui-vendors. folio-testing is running the latest version of mod-gobi. It appears that all the sample data is loaded and the conflicts are resolved. |