[FOLIO-1726] enable sample MARC record data loading in mod-source-record-storage Created: 22/Jan/19 Updated: 03/Jun/20 Resolved: 02/Jul/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P2 |
| Reporter: | Wayne Schneider | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | ci, platform-backlog | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | CP: ready for planning, Core: Platform - Sprint 59 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Story Points: | 1 | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Development Team: | Core: Platform | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
When the sample MARC record data is ready in mod-source-record-storage (Taras Spashchenko please provide the Jira ID for the ticker for this functionality), it will need to be loaded in the reference builds (testing/snapshot/snapshot-core), and the MARC sample data that currently resides in mod-inventory-storage should no longer be loaded (other sample data will continue to be loaded from mod-inventory-storage, including native inventory instances, holdings, items, etc.). Acceptance criteria:
|
| Comments |
| Comment by Wayne Schneider [ 22/Jan/19 ] |
|
The plan is to use a tenant initialization parameter to signal the module to load the data (as in
|
| Comment by Jakub Skoczen [ 23/Jan/19 ] |
|
Wayne Schneider in the description you wrote "the sample data that currently resides in mod-inventory-storage should no longer be loaded". This does not sound correct, the sample data for instances, items and holdings would remain with mod-inventory-storage, only the source data would be handed by srs. Can you clarify this? |
| Comment by Taras Spashchenko [ 13/Feb/19 ] |
|
I added a link to
|
| Comment by Wayne Schneider [ 21/Mar/19 ] |
|
Initial investigation shows no records at /source-storage/sourceRecords or at /source-storage/records, further testing required. |
| Comment by Wayne Schneider [ 21/Mar/19 ] |
|
On inspection, the mod-source-record-storage module descriptor does not advertise the tenant interface v1.2, as required to support passing tenant parameters from Okapi. See https://github.com/folio-org/okapi/blob/master/doc/guide.md#tenant-parameters. Added
|
| Comment by Ann-Marie Breaux (Inactive) [ 21/Mar/19 ] |
|
Taras Spashchenko Oleksii Kuzminov Could you review this ASAP? Looks like Wayne created a bug and linked it to this story. We don't have to get this done before end of Q1, so this is not P1 priority, but I would call it P2 priority. |
| Comment by Wayne Schneider [ 21/Mar/19 ] |
|
The code for
|
| Comment by Ann-Marie Breaux (Inactive) [ 21/Mar/19 ] |
|
Thanks for working on this more Wayne Schneider. We'll take a look at it and be back in touch ASAP. This is not breaking or blocking anything for Core in Q1, right? |
| Comment by Wayne Schneider [ 21/Mar/19 ] |
|
Ann-Marie Breaux – that is correct, this is not a core Q1 blocker. |
| Comment by Ann-Marie Breaux (Inactive) [ 09/May/19 ] |
|
Wayne Schneider Just happened upon this ticket - looks like all the blockers have been completed. Should this story be unblocked and changed to open? |
| Comment by Wayne Schneider [ 10/May/19 ] |
|
Thanks, Ann-Marie Breaux. I've removed myself as the assignee and unblocked it, so it can go into the core platform team's planning for the next week. |
| Comment by Jakub Skoczen [ 07/Jun/19 ] |
|
Wayne Schneider is this story still valid, should those records be loaded via the module (loadSample)? |
| Comment by Wayne Schneider [ 07/Jun/19 ] |
|
Jakub Skoczen I agree, sample records synchronized with the sample records in mod-inventory-storage should be loaded using the loadSample tenant initialization parameter. There may still be value in loading a larger batch of sample records in our reference environments outside this process (as we do now with the MODS record loader in mod-inventory), but IMO that should be done using data import API. |
| Comment by Ann-Marie Breaux (Inactive) [ 07/Jun/19 ] |
|
Flagging Taras Spashchenko and Oleksii Kuzminov in case they have opinion or input on closing this ticket. |
| Comment by Ann-Marie Breaux (Inactive) [ 26/Jun/19 ] |
|
Oleksii Kuzminov Please confirm whether this can be closed, or if we will need to roll forward into Q3? Wayne Schneider Marc Johnson if this is a Core Platform task, then perhaps it's better to link it to a Core-Team feature instead of a Folijet one? |
| Comment by Oleksii Kuzminov [ 26/Jun/19 ] |
|
Ann-Marie Breaux We add params and sample data to the SRS. From Folijet side all stuff is ready. I hope Wayne Schneider can confirm that all is done and we can close this ticket. |
| Comment by Wayne Schneider [ 26/Jun/19 ] |
|
folio-testing, folio-snapshot, and folio-clover reference environments all have data for mod-source-record-storage. It is hard for me to tell if it is the correct sample data, as it appears that people may have been busy loading records since the environments were built – Oleksii Kuzminov or Ann-Marie Breaux, can you confirm the validity of the data? The Okapi endpoints I checked are: https://folio-testing-okapi.aws.indexdata.com/source-storage/records If you can confirm that the data are valid, please feel free to close the ticket. |
| Comment by Ann-Marie Breaux (Inactive) [ 26/Jun/19 ] |
|
I've definitely added data to folio-testing and folio-snapshot-load. I can't get into folio-snapshot right now. Is the goal to have some persistent sample SRS data in the hosted environments, which surfaces as Instances? If that's the case, I'm not sure we've accomplished that yet. Oleksii Kuzminov Wayne Schneider any other thoughts? |
| Comment by Ann-Marie Breaux (Inactive) [ 02/Jul/19 ] |
|
Closing this - we'll write a new ticket if needed |