[FOLIO-1678] Set `license/cla` as required for all `folio-org` GitHub repos Created: 02/Jan/19 Updated: 03/Jun/20 Resolved: 13/Feb/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | Peter Murray | Assignee: | Peter Murray |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: |
| Description |
|
FYI: Details on the Contributor License Agreement (CLA): https://dev.folio.org/guidelines/cla-process/ |
| Comments |
| Comment by Peter Murray [ 02/Jan/19 ] |
|
CLA required check turned on for all but these repos missing master branch protection:
|
| Comment by Peter Murray [ 02/Jan/19 ] |
|
David Crossley: Do you know if some of these are deprecated now? If so, can we prefix the repository names with `deprecated-`? For the others, I can use my newly created script to add the master branch protection checks. |
| Comment by David Crossley [ 02/Jan/19 ] |
|
Regarding the potentially deprecated ones: Comparing with your list: Yes: Maybe: Do not know: |
| Comment by Peter Murray [ 02/Jan/19 ] |
|
David Crossley: The more I think about this, the more I think I want to adapt my program to automatically set branch protections and required CLA checks for all `folio-org` GitHub repos (except those prefixed with `deprecated-` perhaps). That would be fairly easy to do, and it would be a process that we could run every once in a while to make sure these checks remain in place. |
| Comment by David Crossley [ 02/Jan/19 ] |
|
Great idea. I have been separately commencing a script to regularly scan repos to verify some other things, and gather some metadata. I am keen to investigate yours. |
| Comment by David Crossley [ 03/Jan/19 ] |
|
Some repositories are already set as "archived read-only", e.g stripes-redux above. |
| Comment by Peter Murray [ 03/Jan/19 ] |
|
Oooh! I didn't know "archived read-only" was an option. I can check for that instead of the 'deprecated-' prefix. |
| Comment by Julian Ladisch [ 05/Jan/19 ] |
|
vertx-mysql-postgresql-client is in use. RMB uses https://github.com/folio-org/vertx-mysql-postgresql-client/tree/release-connection-pool-3-5-1 : https://github.com/folio-org/raml-module-builder/blob/v23.3.0/domain-models-runtime/pom.xml#L121-L125 |
| Comment by Julian Ladisch [ 05/Jan/19 ] |
|
Is there a technical reason to exclude the cla requirement from deprecated or read-only repositories? Having the cla requirement for each and every repository is less error prone. |
| Comment by Peter Murray [ 07/Jan/19 ] |
|
Hmmm. No, no technical reason. You make a good point, Julian. I'll look at enabling it for all `folio-org` repositories. |
| Comment by Peter Murray [ 13/Feb/19 ] |
|
Now enabled in all repositories. |