[FOLIO-1678] Set `license/cla` as required for all `folio-org` GitHub repos Created: 02/Jan/19  Updated: 03/Jun/20  Resolved: 13/Feb/19

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: P3
Reporter: Peter Murray Assignee: Peter Murray
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Sprint:

 Description   

Zak Julian Ladisch discovered in `folio-org/ui-circulation` that it was possible to merge a pull request without the CLA being signed. That was certainly not the intention of the CLA assistant. Make the CLA required for all `folio-org` repos.

FYI: Details on the Contributor License Agreement (CLA): https://dev.folio.org/guidelines/cla-process/



 Comments   
Comment by Peter Murray [ 02/Jan/19 ]

CLA required check turned on for all but these repos missing master branch protection:

  • stripes-sample-platform
  • stripes-demo-platform
  • stripes-redux
  • stripes-testing
  • container-perf-tests
  • folio-org.github.io
  • folio-sample-modules
  • raml
  • folio-ansible
  • ui-okapi-console
  • folio-tools
  • okapi-debian
  • ui-testing
  • folio-test-env
  • ui-plugin-example
  • ui-trivial
  • react-githubish-mentions
  • mod-rmb-template
  • acq-models
  • mod-pg-embed
  • folio-install
  • react-intl-safe-html
  • mod-tags
  • edge-rtac
  • mod-patron
  • edge-patron
  • folio-perf-test
  • vertx-mysql-postgresql-client
  • folio-graphiql
  • edge-orders
  • ui-myprofile
  • rfcs
  • folio-api-tests
  • ui-receiving
  • platform-complete
  • mod-orders
  • react-hotkeys
  • mod-finance
  • spring-module-core
  • edge-resolver
  • ui-marccat
  • martin-test-repo
  • mod-erm-usage-harvester
  • Net-Z3950-FOLIO
  • raml2html-plain-theme
  • folio-isbn-util
Comment by Peter Murray [ 02/Jan/19 ]

David Crossley: Do you know if some of these are deprecated now? If so, can we prefix the repository names with `deprecated-`? For the others, I can use my newly created script to add the master branch protection checks.

Comment by David Crossley [ 02/Jan/19 ]

Regarding the potentially deprecated ones:
There are also others found while doing another job – will attend to separately.

Comparing with your list:

Yes:
stripes-redux
ui-okapi-console
ui-testing

Maybe:
container-perf-tests
stripes-demo-platform

Do not know:
martin-test-repo
vertx-mysql-postgresql-client

Comment by Peter Murray [ 02/Jan/19 ]

David Crossley: The more I think about this, the more I think I want to adapt my program to automatically set branch protections and required CLA checks for all `folio-org` GitHub repos (except those prefixed with `deprecated-` perhaps). That would be fairly easy to do, and it would be a process that we could run every once in a while to make sure these checks remain in place.

Comment by David Crossley [ 02/Jan/19 ]

Great idea. I have been separately commencing a script to regularly scan repos to verify some other things, and gather some metadata. I am keen to investigate yours.

Comment by David Crossley [ 03/Jan/19 ]

Some repositories are already set as "archived read-only", e.g stripes-redux above.
In a spearate issue we can investigate a consistent way deprecate.

Comment by Peter Murray [ 03/Jan/19 ]

Oooh! I didn't know "archived read-only" was an option. I can check for that instead of the 'deprecated-' prefix.

Comment by Julian Ladisch [ 05/Jan/19 ]

vertx-mysql-postgresql-client is in use. RMB uses https://github.com/folio-org/vertx-mysql-postgresql-client/tree/release-connection-pool-3-5-1 : https://github.com/folio-org/raml-module-builder/blob/v23.3.0/domain-models-runtime/pom.xml#L121-L125
See https://folio-org.atlassian.net/browse/RMB-154 and https://github.com/vert-x3/vertx-mysql-postgresql-client/pull/136

Comment by Julian Ladisch [ 05/Jan/19 ]

Is there a technical reason to exclude the cla requirement from deprecated or read-only repositories? Having the cla requirement for each and every repository is less error prone.

Comment by Peter Murray [ 07/Jan/19 ]

Hmmm. No, no technical reason. You make a good point, Julian. I'll look at enabling it for all `folio-org` repositories.

Comment by Peter Murray [ 13/Feb/19 ]

Now enabled in all repositories.

Generated at Thu Feb 08 23:15:05 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.