[FOLIO-1669] Update build-module-descriptors logic Created: 21/Dec/18 Updated: 03/Jun/20 Resolved: 03/Jan/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | Matthew Jones | Assignee: | Matthew Jones |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||
| Sprint: | |||||||||||||||||
| Description |
|
The platform's build-module-descriptor.js logic suffers from the same reliance on module hoisting as stripes-core's locateStripesModule() function. While the stripes-core logic has been corrected in
In an effort to reduce maintenance, the logic should be shared. As a first step, we can replace the build-module-descriptor.js internals with a call to stripes mod descriptor while maintaining the same input/output. The main difference between this script and the CLI equivalent, is the CLI version returns an array of JSON descriptors rather than writing to individual files. Longer term, the CLI command should include an option to write to files. Doing so would allow this script to be eliminated entirely. |
| Comments |
| Comment by John Malconian [ 02/Jan/19 ] |
|
Changes to build-module-descriptors.js have been merged into snapshot, next-release, and q4-2018 branches of platform-core. I will update platform-complete accordingly as well. |
| Comment by John Malconian [ 02/Jan/19 ] |
|
snapshot, next-release, and q4-2018 branches of platform-complete updated as well. |