[FOLIO-1669] Update build-module-descriptors logic Created: 21/Dec/18  Updated: 03/Jun/20  Resolved: 03/Jan/19

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: P3
Reporter: Matthew Jones Assignee: Matthew Jones
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Relates
relates to STCLI-125 Support writing module descriptors to... Closed
relates to FOLIO-1666 Missing mod-notes on Stable site inst... Closed
relates to STCOR-304 Unable to locate some stripes-* modul... Closed
Sprint:

 Description   

The platform's build-module-descriptor.js logic suffers from the same reliance on module hoisting as stripes-core's locateStripesModule() function. While the stripes-core logic has been corrected in STCOR-304 Closed , build-module-descriptor.js has its own logic and therefore does not benefit.

In an effort to reduce maintenance, the logic should be shared. As a first step, we can replace the build-module-descriptor.js internals with a call to stripes mod descriptor while maintaining the same input/output.

The main difference between this script and the CLI equivalent, is the CLI version returns an array of JSON descriptors rather than writing to individual files. Longer term, the CLI command should include an option to write to files. Doing so would allow this script to be eliminated entirely.



 Comments   
Comment by John Malconian [ 02/Jan/19 ]

Changes to build-module-descriptors.js have been merged into snapshot, next-release, and q4-2018 branches of platform-core. I will update platform-complete accordingly as well.

Comment by John Malconian [ 02/Jan/19 ]

snapshot, next-release, and q4-2018 branches of platform-complete updated as well.

Generated at Thu Feb 08 23:15:02 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.