[FOLIO-1609] Java maven-surefire-plugin broken in Debian/Ubuntu Created: 02/Nov/18 Updated: 20/Nov/18 Resolved: 12/Nov/18 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P2 |
| Reporter: | Adam Dickmeiss | Assignee: | John Malconian |
| Resolution: | Done | Votes: | 0 |
| Labels: | core, sprint50, sprint51 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||||||
| Sprint: | |||||||||||||||||||||||||||||
| Description |
|
This affects all Folio modules using Maven's maven-surefire-plugin . Around Nov 1st Debian/Ubuntu rolled out openjdk packages which makes maven-surefire-plugin fail. At this time, it does not seems that Debian will rewind their regression. For now, you can fix this - with current maven-surefire-plugin by adding:
<configuration>
<useSystemClassLoader>false</useSystemClassLoader>
</configuration>
Eventually a new maven-surefire-plugin should be released (pull request: https://github.com/apache/maven-surefire/pull/197 ). You can then update your pom to use that and may remove the useSystemClassLoader configuration. https://issues.apache.org/jira/browse/SUREFIRE-1588 The cause: |
| Comments |
| Comment by John Malconian [ 08/Nov/18 ] |
|
I'm going to go ahead and make this change to the pom across all maven projects as I can find no other viable workaround and it won't be possible to hold java version back in the CI much longer. However, I have noticed that setting <useSystemClassLoader>false</useSystemClassLoader> in mod-calendar does not work. |
| Comment by Adam Dickmeiss [ 08/Nov/18 ] |
|
For RMB I also had to tweakj maven-failsafe-plugin |
| Comment by Adam Dickmeiss [ 09/Nov/18 ] |
|
Made a PR https://github.com/folio-org/mod-calendar/pull/61 for mod-calender. Indeed this was the maven-failsafe-plugin. |
| Comment by John Malconian [ 09/Nov/18 ] |
|
Thanks, Adam. That fixed mod-calendar. |
| Comment by John Malconian [ 09/Nov/18 ] |
|
Modules updated thus far: mod-authtoken Also using this opportunity to update vertx-core and vertx-web to 3.5.4 to resolve pre 3.5.4 security vulnerabilities. |
| Comment by Adam Dickmeiss [ 09/Nov/18 ] |
|
Note that there is a bug in Vert.x 3.5.4 https://github.com/eclipse-vertx/vert.x/issues/2653 . So if your code has setChunked(false), that will have to be removed. |
| Comment by John Malconian [ 09/Nov/18 ] |
|
Thanks for that. I'll check for that as well. |
| Comment by John Malconian [ 09/Nov/18 ] |
|
latest updates: mod-data-loader |
| Comment by John Malconian [ 09/Nov/18 ] |
|
updated: mod-login |
| Comment by John Malconian [ 09/Nov/18 ] |
|
updated: mod-finance-storage |
| Comment by John Malconian [ 09/Nov/18 ] |
|
updated: mod-audit |
| Comment by John Malconian [ 09/Nov/18 ] |
|
updated: mod-tags |
| Comment by John Malconian [ 09/Nov/18 ] |
|
Other Maven modules that need to be checked: mod-gobi |
| Comment by John Malconian [ 10/Nov/18 ] |
|
Updated: |
| Comment by David Crossley [ 12/Nov/18 ] |
|
Updated: mod-rmb-template |
| Comment by John Malconian [ 12/Nov/18 ] |
|
No changes needed: mod-workflow Updated: mod-aes |
| Comment by John Malconian [ 12/Nov/18 ] |
|
Updated: mod-source-record-manager I think that about does it. |
| Comment by John Malconian [ 12/Nov/18 ] |
|
Implemented workaround as described in this issue for all FOLIO Maven projects. |