[FOLIO-1597] Add module dependency resolution quality gate for PRs in CI Created: 24/Oct/18 Updated: 26/Jun/19 Resolved: 08/Mar/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | John Malconian | Assignee: | John Malconian |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | ci, sprint50 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||
| Sprint: | |||||||||||||||||||||||||
| Development Team: | Core: Platform | ||||||||||||||||||||||||
| Description |
|
All module dependency resolution checking utilizing a tenant install endpoint in Okapi (simulate-mode). The process would look something like the following: 1) deploy an instance of okapi (probably in a container) for each PR. If there is a dependency resolution conflict, the PR fails. If there is no dependency resolution conflict, but the new version of the module is not included in list of modules to enable, a warning message is generated that signifies that no modules are prepared to use the new iteration of the module. This is useful for backend modules that increment the interface version. |
| Comments |
| Comment by John Malconian [ 05/Nov/18 ] |
|
This feature has been implemented in branch
To enable for a UI module, add the following (example) map configuration to the repo's Jenkinsfile: stripesPlatform = [ repo:'platform-core', branch:'snapshot' ] Specifying a 'stripesPlatform' is necessary to ensure dependency checks can be resolved. Currently, dependency checks are tested against all snapshot versions available. However, I believe that this feature is more valuable when checked against 'next-release' (only released versions). Added
|
| Comment by patty.wanninger [ 03/Jan/19 ] |
|
John Malconian Cate Boerema This does not seem like a ticket for the IC testers. |
| Comment by Cate Boerema (Inactive) [ 04/Jan/19 ] |
|
patty.wanninger, true. John Malconian, In Review status means ready for the manual testers. If you are looking for a code review, please use Code Review status or close. Thanks! |
| Comment by Ann-Marie Breaux (Inactive) [ 15/Jan/19 ] |
|
John Malconian I switched this to In Code Review; if you prefer for it to be closed, then close it. Definitely not "In Review" for manual testing. Thank you! |
| Comment by Jakub Skoczen [ 08/Mar/19 ] |
|
John Malconian this has been in "CODE REVIEW" for some time, has it been completed? If so, where can I see the resulting dependency check? |
| Comment by John Malconian [ 08/Mar/19 ] |
|
Jakub Skoczen Based on our discussions, we decided not to do this. Instead we decided to implement this feature on release builds only (separate issue). We can revisit this later if needed. |