[FOLIO-1596] enable platform builds for all ui-* modules PRs in CI Created: 24/Oct/18 Updated: 26/Jun/19 Resolved: 13/May/19 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | John Malconian | Assignee: | John Malconian |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | ci, platform-backlog, sprint49, sprint50 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||||||||||||||||||||||||||
| Sprint: | CP: ready for planning | ||||||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||||||
| Development Team: | Core: Platform | ||||||||||||||||||||||||||||||||
| Description |
|
Re-add platform (webpack) builds as a quality gate for all UI module PRs. This would ensure that build issues are not propagated downstream. Each UI module needs to be configured to use a particular platform - platform-core, platform-complete, platform-erm, etc. Acceptance criteria:
|
| Comments |
| Comment by John Malconian [ 05/Nov/18 ] |
|
This feature has been implemented in branch
To enable for a UI module, add the following map configuration to the repo's Jenkinsfile: stripesPlatform = [ repo:'platform-core', branch:'snapshot' ] where 'repo' is the stripes-platform that the module belongs to and 'branch' which is the branch to build. |
| Comment by Jakub Skoczen [ 20/Nov/18 ] |
|
John Malconian for which particular ui modules this feature has been enabled? |
| Comment by patty.wanninger [ 03/Jan/19 ] |
|
John Malconian Cate Boerema This doesn't seem like an issue for the IC testing team. |
| Comment by Anya [ 15/Jan/19 ] |
|
Should this be in code review Cate Boerema? |
| Comment by John Malconian [ 28/Jan/19 ] |
|
Jakub Skoczen After re-thinking this, I don't believe we should implement this right now for a few reasons:
|
| Comment by Jakub Skoczen [ 13/May/19 ] |
|
John Malconian should we close this as WONTDO in favour of
|
| Comment by John Malconian [ 13/May/19 ] |
|
See
|