[FOLIO-1596] enable platform builds for all ui-* modules PRs in CI Created: 24/Oct/18  Updated: 26/Jun/19  Resolved: 13/May/19

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: P3
Reporter: John Malconian Assignee: John Malconian
Resolution: Won't Do Votes: 0
Labels: ci, platform-backlog, sprint49, sprint50
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Issue links:
Blocks
blocks UXPROD-1827 CI-integrated continuous deployment (... Closed
blocks FOLIO-2118 CI-integrated continuous deployment (... Closed
is blocked by FOLIO-1577 Automated builds for FOLIO 'release' Closed
is blocked by FOLIO-1948 PoC preview capability for PRs in a p... Closed
Relates
relates to UXPROD-1133 Pull Request builds and integration t... Closed
relates to UXPROD-1423 Pull Request builds and integration t... Closed
Sprint: CP: ready for planning
Story Points: 5
Development Team: Core: Platform

 Description   

Re-add platform (webpack) builds as a quality gate for all UI module PRs. This would ensure that build issues are not propagated downstream. Each UI module needs to be configured to use a particular platform - platform-core, platform-complete, platform-erm, etc.

Acceptance criteria:

  • demostrate a platform build being initiated for all ui modules that are part of platform-core


 Comments   
Comment by John Malconian [ 05/Nov/18 ]

This feature has been implemented in branch FOLIO-1596 Closed of jenkins-pipeline-libs. Here's a example PR:
https://jenkins-aws.indexdata.com/job/folio-org/job/ui-users/view/change-requests/job/PR-557/35/console

To enable for a UI module, add the following map configuration to the repo's Jenkinsfile:

stripesPlatform = [ repo:'platform-core', branch:'snapshot' ]

where 'repo' is the stripes-platform that the module belongs to and 'branch' which is the branch to build.

Comment by Jakub Skoczen [ 20/Nov/18 ]

John Malconian for which particular ui modules this feature has been enabled?

Comment by patty.wanninger [ 03/Jan/19 ]

John Malconian Cate Boerema This doesn't seem like an issue for the IC testing team.

Comment by Anya [ 15/Jan/19 ]

Should this be in code review Cate Boerema?

Comment by John Malconian [ 28/Jan/19 ]

Jakub Skoczen After re-thinking this, I don't believe we should implement this right now for a few reasons:

  • PR builds currently test against the 'snapshot' branch of platform-core/complete which is, by its nature, volatile and unstable. A successful snapshot build of the stripes platforms is not necessarily signify any kind of stability since the NPM dependency rules in snapshot are fairly loose. The only reason to implement this is to lessen the chance of a build failure in folio-testing and folio-snapshot.
  • We've already implemented a solution which lessens the chance of a folio-testing and folio-snapshot build failure. A job in Jenkins currently exists which builds the snapshot branches of platform-core and platform-complete. The job runs hourly and and updates the yarn.lock in each repo if the build is successful. The folio-testing and folio-snapshot builds uses this yarn.lock.
  • FOLIO-1739 Closed and FOLIO-1738 Closed include platform (webpack) builds that will be run when new NPM dependencies are introduced to the platform as part of the PR build pipeline - accomplishing a similar goal.
Comment by Jakub Skoczen [ 13/May/19 ]

John Malconian should we close this as WONTDO in favour of FOLIO-2011 Closed ?

Comment by John Malconian [ 13/May/19 ]

See FOLIO-2011 Closed

Generated at Thu Feb 08 23:14:30 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.