[FOLIO-1419] establish consistent lint versions across environments Created: 17/Aug/18  Updated: 18/Jan/19

Status: Open
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Task Priority: P3
Reporter: Zak Burke Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Sprint:
Development Team: Core: Platform

 Description   

ESLint returns different results in CI (on pull requests) and when running locally. A local run may be clean:

[05:36] zburke@lib-zdb9-maclap ui-plugin-find-instance(master) 
$ yarn lint
yarn run v1.9.4
$ eslint *.js settings InstanceSearch
✨  Done in 5.93s.

but there are errors in CI on the same branch:

yarn run v1.6.0
$ eslint *.js settings InstanceSearch
/home/jenkins/workspace/folio-org/ui-plugin-find-instance/PR-1/project/InstanceSearch/InstanceSearch.js
49:24  error  Must use destructuring props assignment  react/destructuring-assignment
54:12  error  Must use destructuring props assignment  react/destructuring-assignment
54:37  error  Must use destructuring props assignment  react/destructuring-assignment
57:21  error  Must use destructuring state assignment  react/destructuring-assignment

/home/jenkins/workspace/folio-org/ui-plugin-find-instance/PR-1/project/InstanceSearch/InstanceSearchModal.js
35:5   error  Must use destructuring props assignment  react/destructuring-assignment
42:5   error  Must use destructuring props assignment  react/destructuring-assignment
55:59  error  Must use destructuring props assignment  react/destructuring-assignment
57:12  error  Must use destructuring state assignment  react/destructuring-assignment
57:67  error  Must use destructuring state assignment  react/destructuring-assignment
61:37  error  Must use destructuring props assignment  react/destructuring-assignment

✖ 10 problems (10 errors, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.


 Comments   
Comment by Zak Burke [ 17/Aug/18 ]

In the example from the description, the package.json file specifies an ESLint version and a recent version of @folio/eslint-config-stripes so I'm not sure where the discrepancy is creeping in. My local version of yarn is newer (1.9.4 vs 1.6) but I don't think that should be relevant here.

Generated at Thu Feb 08 23:13:12 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.