[FOLIO-1418] Patron look up modal in Checkout only displays 13 patron groups Created: 16/Aug/18  Updated: 12/Nov/18  Resolved: 24/Sep/18

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P2
Reporter: patty.wanninger Assignee: Rasmus Wølk
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File Patron lookup window too small.PNG     PNG File screenshot-1.png    
Issue links:
Relates
relates to UIU-600 Patron group filter on users page lac... Closed
Sprint:

 Description   

Steps to reproduce:

  1. Log into snapshot-stable
  2. Go to Settings > Users > Patron groups and add patron groups until there are more than 13
  3. In Checkout, Select "Patron look up" to open the patron lookup modal

Expected result: Patron lookup modal should display all patron groups

Actual result: Only 13 show. The scroll bar for the filters goes to the bottom of the window but the window cuts off the last patron group. No way to resize the window.

Additional Info:

  • In UIU-600 Closed , it was decided that we should code to support 40 patron groups
  • Using chrome on a windows 10 machine


 Comments   
Comment by Zak Burke [ 11/Sep/18 ]

The problem here is not the number of groups but rather how the scrolling height is calculated in the search pane. Inspecting the DOM will show that all the patron groups are, in fact, rendered, but the content at the bottom of the pane is clipped. It'll take somebody with more CSS chops than me to figure out the right adjustment/calculation here.

Rasmus Wølk, John Coburn, Jeffrey Cherewaty, Wil Wilsman, is this something one of you CSS experts knows how to handle?

Comment by Rasmus Wølk [ 21/Sep/18 ]

The problem here is that it's the content of the "Users"-app (which renders a SearchAndSort) that are placed inside of a <Modal> but it was never really made to be used in that way. It usually replaces the entire content area and I guess the styling is adjusted for the universal header of the FOLIO app.

I looked into it and it seems that it shouldn't be very difficult to fix the issue.

However, this user look-up modal is, in general, a bit weird with it's two "close"-buttons and double pane headers. Maybe we could adjust it to look something like this:

Comment by Rasmus Wølk [ 21/Sep/18 ]

Submitted a PR to fix this:
https://github.com/folio-org/ui-plugin-find-user/pull/37

Comment by Rasmus Wølk [ 24/Sep/18 ]

Fixed in https://github.com/folio-org/ui-plugin-find-user/pull/37

Generated at Thu Feb 08 23:13:11 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.