[FOLIO-1377] debug PR test failure issue in ui-inventory Created: 25/Jul/18 Updated: 12/Nov/18 Resolved: 25/Jul/18 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P1 |
| Reporter: | Jakub Skoczen | Assignee: | Niels Erik Nielsen |
| Resolution: | Done | Votes: | 0 |
| Labels: | sprint43 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue links: |
|
||||||||
| Sprint: | |||||||||
| Description |
|
Niels Erik Nielsen on
From John: Steps that simulate a PR build in Jenkins (using ui-users as example): Prep Project Repo: Checkout a "feature" branch of a UI module. Merge master branch into branch. Clone 'platform-core' from Git. For the sake of manual testing, this step can be skipped. Use an existing tenant. git clone ui-testing repo _admin set env FOLIO_UI_PASSWORD to 'admin' |
| Comments |
| Comment by Niels Erik Nielsen [ 25/Jul/18 ] |
|
Jakub Skoczen and found that it errors out for several UI modules with messages like this: This would explain the PR test failures. |
| Comment by Niels Erik Nielsen [ 25/Jul/18 ] |
|
I went through the same steps, and still find that behavior for ui-users and ui-inventory. With ui-user checkout, no yarn.lock rm -rf platform-core git clone https://github.com/folio-org/platform-core cd platform-core yarn add file:../ui-users && yarn upgrade @folio/users stripes build --okapi http://folio-snapshot-stable.aws.indexdata.com:9130 --tenant diku stripes.config.js bundle http-server -p 3000 ./bundle |
| Comment by Niels Erik Nielsen [ 25/Jul/18 ] |
|
Finally, yarn adding ui-inventory (instead of ui-users as before): rm -rf platform-core git clone https://github.com/folio-org/platform-core cd platform-core yarn add file:../ui-inventory && yarn upgrade @folio/inventory stripes build --okapi http://folio-snapshot-stable.aws.indexdata.com:9130 --tenant diku stripes.config.js bundle http-server -p 3000 ./bundle |
| Comment by Niels Erik Nielsen [ 25/Jul/18 ] |
|
Conclusion: Both ui-user and ui-inventory consistently error out when they are "yarn added", using the build steps given in the description (excluding fetching the yarn.lock which breaks stripes build for me). The same modules (same versions) work if they are installed as part of a regular yarn install – that is, doing the same steps but not yarn add-ing particular modules. Cannot look into the past, but if my scripts reflect what's happening in the PR, I'm guessing these errors are why the PR's have consistently failed for some time. |
| Comment by Niels Erik Nielsen [ 26/Jul/18 ] |
|
As suggested on the testing meet just now, this is a test run based on the ui-inventory PR test build. It fails according to the same pattern as all the PR tests for ui-inventory, ui-users, and others in recent weeks. (The service built with: rm -rf platform-core git clone https://github.com/folio-org/platform-core cd platform-core yarn add file:../ui-inventory && yarn upgrade @folio/inventory stripes build --okapi http://folio-snapshot-stable.aws.indexdata.com:9130 --tenant diku stripes.config.js bundle http-server -p 3000 ./bundle ) |