[FOLIO-1271] snapshot Ansible builds failing Created: 06/Jun/18 Updated: 12/Nov/18 Resolved: 12/Jun/18 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | P1 |
| Reporter: | Wayne Schneider | Assignee: | Niels Erik Nielsen |
| Resolution: | Done | Votes: | 0 |
| Labels: | ci, sprint39, sprint40 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Sprint: |
| Description |
|
Both the snapshot Vagrant build and the snapshot AWS build failed overnight: At a glance, it looks like a problem with dependencies for ui-inventory. |
| Comments |
| Comment by Wayne Schneider [ 06/Jun/18 ] |
|
Indeed, it looks like ui-inventory requires v2.0 of the contributor-types, instance-types, and instance-formats interfaces, while the current HEAD of master for mod-inventory-storage provides v1.1. |
| Comment by Wayne Schneider [ 06/Jun/18 ] |
|
Commits: Might be tricky to roll back. |
| Comment by Wayne Schneider [ 06/Jun/18 ] |
|
Running the ui-testing suite against folio-testing (which should be basically the same system as what would be built for folio-snapshot, except without front- to backend dependency resolution) shows a warning for the interface mismatches, as expected, and the following errors. Hard for me to tell if they might be related to the ui-inventory changes – charles, Niels Erik Nielsen, any idea? Module test: checkout:error_messages.
Open app > Trigger error messages > Logout
Test suite @folio/checkout:1.1.3000146
Live module @folio/checkout:1.1.3000144 (http://folio-testing.aws.indexdata.com/)
✓ should open app and find module version tag (151ms)
✓ should show error when scanning item before patron card (308ms)
✓ should show error when entering wrong patron ID (911ms)
✓ should set patron scan ID to "User" (897ms)
1) should find existing patron
2) should show error when entering wrong item ID
Module test: users:new_proxy
Login > Find user two users > Add proxy to user 1 > Delete sponsor in user 2 > Logout
3) "before all" hook
4) "after all" hook
Module test: inventory:filters
Login > Open module "Inventory" > Get hit counts > Click filters > Logout
5) "before all" hook
6) "after all" hook
Module test: inventory:inventorySearch
Login > Click Inventory > Ente Search Term > Wait for Results > Confirm search term at top of results > Click Reset All > Wait for results pan to change state > Logout
7) "before all" hook
8) "after all" hook
Module test: requests:new_request
Login > Open module "Requests" > Create new request > Logout
9) "before all" hook
10) "after all" hook
Module test: circulation:settings
Login > Open Circulation settings > Logout
11) "before all" hook
12) "after all" hook
1) Module test: checkout:error_messages. Open app > Trigger error messages > Logout should find existing patron:
Error: .wait() timed out after 30000msec
at Timeout._onTimeout (node_modules/nightmare/lib/actions.js:453:10)
2) Module test: checkout:error_messages. Open app > Trigger error messages > Logout should show error when entering wrong item ID:
Error: done() invoked with non-Error: Cannot read property 'focus' of null
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
3) Module test: users:new_proxy Login > Find user two users > Add proxy to user 1 > Delete sponsor in user 2 > Logout
"before all" hook:
Error: .wait() timed out after 30000msec
at Timeout._onTimeout (node_modules/nightmare/lib/actions.js:453:10)
4) Module test: users:new_proxy Login > Find user two users > Add proxy to user 1 > Delete sponsor in user 2 > Logout
"after all" hook:
Error: done() invoked with non-Error: Unable to find element by selector: #clickable-logout
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
5) Module test: inventory:filters Login > Open module "Inventory" > Get hit counts > Click filters > Logout "before all" hook:
Error: .wait() timed out after 30000msec
at Timeout._onTimeout (node_modules/nightmare/lib/actions.js:453:10)
6) Module test: inventory:filters Login > Open module "Inventory" > Get hit counts > Click filters > Logout "after all" hook:
Error: done() invoked with non-Error: Unable to find element by selector: #clickable-logout
at <anonymous>
at process._tickCallback (internal/process/next_tick.js:188:7)
7) Module test: inventory:inventorySearch Login > Click Inventory > Ente Search Term > Wait for Results > Confirm search term at top of results > Click Reset All > Wait for results pan to change state > Logout
"before all" hook:
Error: .wait() timed out after 30000msec
at Timeout._onTimeout (node_modules/nightmare/lib/actions.js:453:10)
8) Module test: inventory:inventorySearch Login > Click Inventory > Ente Search Term > Wait for Results > Confirm search term at top of results > Click Reset All > Wait for results pan to change state > Logout
"after all" hook:
Error: done() invoked with non-Error: Unable to find element by selector: #clickable-logout
at <anonymous>
9) Module test: requests:new_request Login > Open module "Requests" > Create new request > Logout "before all" hook:
Error: .wait() timed out after 30000msec
at Timeout._onTimeout (node_modules/nightmare/lib/actions.js:453:10)
10) Module test: requests:new_request Login > Open module "Requests" > Create new request > Logout "after all" hook:
Error: done() invoked with non-Error: Unable to find element by selector: #clickable-logout
at <anonymous>
11) Module test: circulation:settings Login > Open Circulation settings > Logout "before all" hook:
Error: .wait() timed out after 30000msec
at Timeout._onTimeout (node_modules/nightmare/lib/actions.js:453:10)
12) Module test: circulation:settings Login > Open Circulation settings > Logout "after all" hook:
Error: done() invoked with non-Error: Unable to find element by selector: #clickable-logout
at <anonymous>
|
| Comment by Wayne Schneider [ 06/Jun/18 ] |
|
With this commit: https://github.com/folio-org/ui-inventory/commit/f6f4a63f90b78db8a3bfccb438921bcb4ed6f46a I am able to successfully build a snapshot system which passes all ui-testing tests locally. I created a PR: https://github.com/folio-org/ui-inventory/pull/203 ...and requested a review from Niels Erik Nielsen (to make sure I didn't screw something up) and from John Malconian (to make sure that the CI will correctly generate a module descriptor for the repository). Assigning the issue to Niels Erik Nielsen. |
| Comment by Niels Erik Nielsen [ 12/Jun/18 ] |
|
I see. I was aware that the regression test would flag the missing dependency, but was under the obviously false impression that the system would still build. Thank you, Wayne Schneider, John Malconian |