[FOLIO-1260] Improve scripts/lint-raml-cop.sh to enable old bash version Created: 25/May/18  Updated: 12/Nov/18  Resolved: 30/May/18

Status: Closed
Project: FOLIO
Components: None
Affects versions: None
Fix versions: None

Type: Bug Priority: P3
Reporter: David Crossley Assignee: David Crossley
Resolution: Done Votes: 0
Labels: raml
Remaining Estimate: Not Specified
Time Spent: 3 hours, 20 minutes
Original estimate: Not Specified

Issue links:
Relates
relates to FOLIO-1027 Integrate RAML linting for all raml-b... Closed
relates to FOLIO-1187 Add scripts/lint-raml-cop.sh to each ... Closed
Sprint:

 Description   

Currently using bash4+ 'mapfile'



 Comments   
Comment by David Crossley [ 25/May/18 ]

See discussion on the primary copy of the file at the following commit
https://github.com/folio-org/mod-notes/commit/a7835788f98314037b4029d5d4149b765639c556

Comment by David Crossley [ 25/May/18 ]

Mike Taylor Please see the updated script in mod-notes.

Marc raised this bash4 problem with me a few weeks ago. I should have spent more time on it then. Sorry.

I would be pleased to have any other feedback. It now needs to be updated in all of the other raml-using repositories. The "raml" and "mod-data-loader" repos are better tests for it.

Comment by Mike Taylor [ 25/May/18 ]

Hey, that's great – thanks!

My other question, maybe more fundamental, is why we have all these redundant and potentially diverging copies of the script at all. Why not just a single copy in one of more fundamental repositories – raml-module-builder, maybe – and let all the repos use it? A bit like how lots of documents across FOLIO have tables of contents generated using the sole copy of the md2toc in the Okapi repo at https://github.com/folio-org/okapi/blob/master/doc/md2toc

Comment by David Crossley [ 30/May/18 ]

When i started FOLIO-1027 Closed i tried doing it that way. For some reason i decided against it and went with the standalone script one-per-repo. I will try again.

Going to use folio-tools, where we could also put various other useful FOLIO-wide items.

Comment by David Crossley [ 30/May/18 ]

Done for bash3. This script at mod-notes will move to FOLIO-1264 Closed .

Comment by Mike Taylor [ 30/May/18 ]

Nice!

Generated at Thu Feb 08 23:12:01 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.