[FOLIO-1224] Create standalone HTML/CSS for FOLIO-wide navbar Created: 24/Apr/18 Updated: 12/Nov/18 Resolved: 21/Jun/18 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | Peter Murray | Assignee: | Peter Murray |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 3 hours, 15 minutes | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||
| Issue links: |
|
||||||||||||||||||||||||||||
| Sprint: | |||||||||||||||||||||||||||||
| Comments |
| Comment by David Crossley [ 26/Apr/18 ] |
|
I am seeing a minor misbehaviour with adding this to the dev.f.o site. The menu dropdown does properly descend in front of the second menubar below it. Happens with Firefox and Chrome on both Linux and macOS, but is okay with Safari It was also happening prior to the recent branch in
|
| Comment by Peter Murray [ 27/Apr/18 ] |
|
> The menu dropdown does properly descend in front of the second menubar below it. When the dropdown is dismissed then it sneaks back up behind rather than in front. Wow – sharp eyes. I didn't see that before, but yes I see it now. I haven't looked at the CSS of the secondary navbar on dev.f.o, but I did have to lift the ULs making up the dropdown menus in order to get them to appear above the secondary navbar. I suspect there is a z-index somewhere in the CSS of the secondary navbar that might be a cause. We can also turn off the animation of the dropdowns, too. I'm going to work on making the project-wide navbar mobile-aware first, then I'll come back to this. |
| Comment by David Crossley [ 01/May/18 ] |
|
Recent changes to the projectwide-navbar have fixed that issue. Probably because now not doing the transition on the dropdowns. |
| Comment by Peter Murray [ 16/Jun/18 ] |
|
I've fixed the problems with the mobile display of the projectwide navbar in the folio-1224-standalone-topbar branch (see it in its staging area here: http://folio-1224-standalone-topbar.dev.folio.org.s3-website-us-east-1.amazonaws.com/). The only thing I can't see to get to show up is the title of the site in the mobile display. David Crossley: any thoughts on how to make that happen? |
| Comment by David Crossley [ 19/Jun/18 ] |
|
Hooray. Well done Peter. See today's comments specific to dev.folio.org over at
|