[FOLIO-1184] External links in submenus of Jekyll Classic do not work Created: 09/Apr/18 Updated: 12/Nov/18 Resolved: 10/Apr/18 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | Documentation |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | P3 |
| Reporter: | Peter Murray | Assignee: | David Crossley |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 2 hours, 5 minutes | ||
| Original estimate: | Not Specified | ||
| Issue links: |
|
||||||||
| Sprint: | |||||||||
| Description |
|
I've added a link to `tutorials/overview.md` that is external to this repository, but what is built by Jekyll includes a leading slash, which makes it relative to dev.folio.org rather than an absolute link: <div class="subitem"> <div class="sub-hasLink"> <div class="disclosure"><p></p></div> <div class="title"> <a href="/https://github.com/folio-org/folio-install/blob/master/single-server.md#folio-deployment-single-server"><p>Single Server Deployment</p></a> </div> </div> </div> This is the YAML: - title: Single Server Deployment url: "https://github.com/folio-org/folio-install/blob/master/single-server.md" link: yes index: 3 anchorId: folio-deployment-single-server The first example under the "Frontmatter" heading of http://www.balancingrock.nl/classic-jekyll-theme/pages/classic/04-menus.html seems to make me think this is the correct configuration. |
| Comments |
| Comment by David Crossley [ 10/Apr/18 ] |
|
Added as upstream issue: |
| Comment by David Crossley [ 10/Apr/18 ] |
|
Wow, so good. It is fixed, and i upgraded the configuration via the beaut remote-jekyll-theme in our branch. |
| Comment by Peter Murray [ 10/Apr/18 ] |
|
I don't think he cut a release with the fix in it. Do we need to set the Jekyll configuration to move to the head branch of classic-jekyll-theme? |
| Comment by Peter Murray [ 10/Apr/18 ] |
|
Noting the commit: Issue 20 should be fixed ยท Balancingrock/classic-jekyll-theme@d4ac9cb |
| Comment by David Crossley [ 10/Apr/18 ] |
|
Yes i already did move the configuration in your branch. See my comment three above. |
| Comment by Peter Murray [ 11/Apr/18 ] |
|
Ah, I missed that – thank you. |