[FOLIO-1128] Update ramls for mod-feesfines to use filename $ref in schema Created: 15/Mar/18 Updated: 12/Nov/18 Resolved: 15/Mar/18 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | David Crossley | Assignee: | David Crossley |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 4 hours, 55 minutes | ||
| Original estimate: | Not Specified | ||
| Sprint: |
| Description |
|
This repository was based on an older version of another repository. Now we do not use the symlink method for the $ref in a parent JSON schema to refer to another schema, instead we now use filename. See the comments toward the end of
Also the raml-util is better positioned inside the ramls directory. |
| Comments |
| Comment by David Crossley [ 15/Mar/18 ] |
|
The re-arrangement is now done in pull/5 |
| Comment by David Crossley [ 15/Mar/18 ] |
|
There are some remaining issues which can be addressed separately: The raml-util is not yet a git submodule. It is a copy of the files as at 6df456f (25 Oct 2017). I have left that as-is for now. There are also some extra schema files in 'ramls/raml-util/schemas/mod-feefines/*.json' which are not yet utilised in the RAMLs. If these truly do need to be shared with other modules, then they need to be moved to the shared "raml" repository. The schema use the old-style "total_records" whereas we now use "totalRecords" via the "resultInfo" schema in a newer raml-util. The raml-cop shows some issues with examples having additional properties that are not declared in the schema. The build copies the ramls directory to 'src/main/resources' by POM "copy-resources-3". Is that necessary? |