[FOLIO-1125] Codex search results navigation problem 1: Infinite scroll Created: 14/Mar/18 Updated: 12/Nov/18 Resolved: 30/May/18 |
|
| Status: | Closed |
| Project: | FOLIO |
| Components: | None |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Bug | Priority: | P2 |
| Reporter: | Ann-Marie Breaux (Inactive) | Assignee: | Adam Dickmeiss |
| Resolution: | Done | Votes: | 0 |
| Labels: | core, sprint34, sprint35, sprint36, sprint37, sprint38, sprint39 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 4 hours, 45 minutes | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||
| Issue links: |
|
||||||||||||||||||||||||||||||||
| Sprint: | |||||||||||||||||||||||||||||||||
| Description |
|
Overview: Infinite scroll not working Steps to Reproduce: See attached video Codex Navigation Bug 1 - Infinite Scroll.mp4. Infinite scroll seems to bog down and never brings back complete results. Log into FOLIO Snapshot Stable as diku_admin Expected Results: I should be able to scroll through all 400+ results Actual Results: I get through the first 50ish, and then I can't scroll any further. A few more results fill in over time, but not sorting properly. I definitely don't get all the results, because I'm missing any titles starting with letters after F, when alphabetized. It seems like the infinite scroll is bogging down. Interested Parties:Cate Boerema |
| Comments |
| Comment by Cate Boerema (Inactive) [ 15/Mar/18 ] |
|
Thanks Ann-Marie Breaux. This should really be filed as 3 different issues. Can you please split it up when you have the chance? Thanks! |
| Comment by Ann-Marie Breaux (Inactive) [ 20/Mar/18 ] |
|
thanks Cate Boerema See
|
| Comment by Adam Dickmeiss [ 19/Apr/18 ] |
|
Need a working mod-codex-ekb to work with in order to even start looking.. See
|
| Comment by Adam Dickmeiss [ 09/May/18 ] |
|
mod-inventory-storage fails after some pages due to this response:
{
"instances" : [ ],
"resultInfo" : {
"totalRecords" : 1,
"facets" : [ ],
"diagnostics" : [ {
"source" : "mod-codex-ekb-0.0.6-SNAPSHOT.59",
"code" : "400",
"message" : "\n 'limit' parameter is incorrect. parameter value {120} is not valid: must be less than or equal to 100"
}, {
"source" : "mod-codex-inventory-1.1.1-SNAPSHOT.51",
"code" : "200",
"recordCount" : 1,
"query" : "title = \"first peoples*\" sortby title"
} ]
}
}
|
| Comment by Adam Dickmeiss [ 09/May/18 ] |
|
Which goes back to the universal question about why we have limits like that.. |
| Comment by Marc Johnson [ 10/May/18 ] |
|
Adam Dickmeiss This is odd, as mod-inventory-storage has the updated trait which should allow limit and offset up to 2147483647. Will investigate. |
| Comment by Marc Johnson [ 10/May/18 ] |
|
Adam Dickmeiss Am I interpreting the diagnostics correctly, it looks like it is mod-codex-ekb that is refusing the larger limit, rather than mod-inventory-storage? (I've just written a test for mod-inventory-storage, and it seems to accept large limit and offset - although weirdly the count looks wrong)
"diagnostics" : [ {
"source" : "mod-codex-ekb-0.0.6-SNAPSHOT.59",
"code" : "400",
"message" : "\n 'limit' parameter is incorrect. parameter value {120} is not valid: must be less than or equal to 100"
}
|
| Comment by Adam Dickmeiss [ 11/May/18 ] |
|
Right, Marc Johnson.. Created
|
| Comment by Adam Dickmeiss [ 15/May/18 ] |
|
Today another problem is reported from mod-codex-ekb: Request:
{
"instances" : [ ],
"resultInfo" : {
"totalRecords" : 2,
"facets" : [ ],
"diagnostics" : [ {
"source" : "mod-codex-inventory-1.1.1-SNAPSHOT.51",
"code" : "200",
"recordCount" : 2,
"query" : "title = water* sortby title"
}, {
"source" : "mod-codex-ekb-0.0.6-SNAPSHOT.60",
"code" : "500",
"message" : "Invalid RMAPI response Code = 400 Message = Bad Request"
} ]
}
}
|
| Comment by Adam Dickmeiss [ 16/May/18 ] |
|
So should I make a bug for mod-codex-ekb ? Is a limitation of 100 records real? |
| Comment by Mike Taylor [ 16/May/18 ] |
|
Yep, file on mod-codex-ekb. Either it'll get fixed, or we'll find out why it can't be. |
| Comment by Adam Dickmeiss [ 30/May/18 ] |
|
Appears to be working now. |