Agreements (UXPROD-573)

[ERM-428] Manage amendment status on agreement/license link Created: 13/Aug/19  Updated: 01/Nov/19  Resolved: 23/Sep/19

Status: Closed
Project: ERM Platform
Components: ui-agreements
Affects versions: None
Fix versions: None
Parent: Agreements

Type: Story Priority: TBD
Reporter: Owen Stephens Assignee: steve.osguthorpe
Resolution: Done Votes: 0
Labels: erm
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File edit linked amendments.png     PNG File screenshot-2.png    
Issue links:
Defines
defines UXPROD-1472 Manage amendments on a license/agreem... Closed
Duplicate
is duplicated by UXPROD-1996 Display amendments in Agreement edit ... Closed
Relates
relates to STCOM-592 Create Message Banner component Closed
relates to ERM-463 Agreement | Add Amendment 'Conflictin... Closed
relates to ERM-544 Agreement | Warning messages in edit ... Closed
Sprint: ERM Sprint 72
Development Team: Bienenvolk
Epic Link: Agreements

 Description   

Users who can link licenses to an agreement can manage the status of related amendments in the context of that agreement.

In the edit agreement view, the following information is set for any amendment link:

  • "Status (this agreement)" (required, no default)
    • Current
    • Future
    • Historical
    • Does not apply
  • "Amendment note" (optional, paragraph text)

All available amendments are presented in the Edit view, as per the attached wireframe, including the following non-editable fields taken from the amendment:

  • status
  • start date
  • end date

A "Conflicting status" warning message is shown if both these conditions are met:

  • amendment has Current status (in agreement context)
  • amendment status (in license) is either Expired or Rejected OR amendment start date is in the future OR amendment end date is in the past

The message is presented as per the attached image.



 Comments   
Comment by Jag Goraya [ 26/Aug/19 ]

From ERM subgroup discussion 2019-08-21:

Are these statuses sufficient?

Yes

Should we warn users when they have "Current" amendments (in Agreement context) that have non Active status or have start dates in future/end dates in past?

Yes

Should there be a default status? If so, what should it be?

Mixed views. Default to no.

Should it be possible to edit Amendment statuses on all Agreement-License links, or only when the License has status of Controlling?

Gill Osguthorpe I'm not clear from Q7 (and Q9 / Q10) in the meeting notes where this is a "yes but only if there's a separate interface". Can you advise please?

Comment by Gill Osguthorpe [ 27/Aug/19 ]

I'm not clear from Q7 (and Q9 / Q10) in the meeting notes where this is a "yes but only if there's a separate interface". Can you advise please?

The short answer is Yes Jag Goraya it should be possible to edit Amendment statuses on all Agreement-License links (not just for the Controlling license).

This is probably not the right place to say this but...
The overarching issue is that the Agreement-License relationship can have a lot of information attached to it and this poses potential display problems. In addition to the Controlling license, users would like to be able to see future licenses, historical licenses and the amendments which applied to an agreement. For the Controlling license, they need to be able to see which amendments used to to apply and will apply in the future.

Currently there is one accordion for display of the Agreement-License, which isn't going to be able to take the strain. Possible options to explore:

  • Abstracting away the Agreement-License relationship and managing it in a separate UI
  • Introducing new ways to present and navigate the license-agreement relationship and associated entities - something for the longer term

This is what "yes but only if there's a separate interface" alludes to. A shorter term option is to restructure, in the UI, presentation of the agreement-license relationship. Something like this:
Unable to render embedded object: File (screenshot-1.png) not found.

I'm floating this option by users, for feedback.

Comment by Gill Osguthorpe [ 27/Aug/19 ]

Jag Goraya I have a WIP mockup for:

Should we warn users when they have "Current" amendments (in Agreement context) that have non Active status or have start dates in future/end dates in past?

Users would like to be warned when:

Status (this agreement)="Current" AND

Amendment Status is in ("Expired", "Rejected")

OR

Amendment End date is in the past

OR

Amendment Start date is in the future

I need to check with md331 about the presentation of the Warning and the message content, which could be something like this:

Comment by steve.osguthorpe [ 13/Sep/19 ]

md331 Added the model for this. linked Licenses now has an array object that you can add amendmentsId/status pairs to. Note nothing special happens with these, they aren't fetched as they are already part of the license that is embedded.
Properties are as below:

String amendmentId

@Defaults(['Current', 'Future', 'Historical', 'Does not apply'])
RefdataValue status

String note

Comment by md331 (Inactive) [ 17/Sep/19 ]

Full functionality (the banners) requires STCOM-592 Closed . We can provide alternative styling until that is completed, so I'm not marking this as Blocked.

Generated at Fri Feb 09 00:20:16 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.