[ERM-390] Manage License term value pick list values (refdata values) Created: 12/Aug/19 Updated: 09/Sep/19 Resolved: 09/Sep/19 |
|
| Status: | Closed |
| Project: | ERM Platform |
| Components: | ui-licenses |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Story | Priority: | TBD |
| Reporter: | Owen Stephens | Assignee: | steve.osguthorpe |
| Resolution: | Done | Votes: | 0 |
| Labels: | erm | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue links: |
|
||||||||||||||||
| Sprint: | ERM Sprint 70, ERM Sprint 71 | ||||||||||||||||
| Development Team: | Bienenvolk | ||||||||||||||||
| Description |
|
Administrators can add license term value pick list values (refdata values) as well as remove them or edit their details. Permission to edit these details are separate to those of other ERM permission sets Workflow / UI Notes
Data stored for pick list terms (refdata values):
Display fields:
Business rules/constraints Wireframes |
| Comments |
| Comment by steve.osguthorpe [ 12/Aug/19 ] |
|
Mike Taylor has implemented something as part of Reshare. |
| Comment by steve.osguthorpe [ 12/Aug/19 ] |
|
https://github.com/openlibraryenvironment/ui-directory/blob/master/src/settings/StatusSettings.js |
| Comment by md331 (Inactive) [ 12/Aug/19 ] |
|
steve.osguthorpe based on Mike Taylor's code there, it almost looks like the endpoint for PUTting an updated Yes record would be something like .../refdata/YesNoOther rather than .../refdata/YesNoOther/Yes. The latter is used throughout Folio and honestly kind of what I expected so I'm trying to make sure that I'm reading things correctly. Similarly, there's no DELETE endpoint, just the usage of the _delete-flag pattern. Can you confirm that no DELETE endpoint actually exists? |
| Comment by Mike Taylor [ 13/Aug/19 ] |
|
Hi, md331. It took a bit of back and forth with steve.osguthorpe to figure out the details of how the Refdata API works, but once I had it straight I wrote it up at https://github.com/openlibraryenvironment/ui-directory/blob/master/doc/refdata-api.md I updated the <ControlledVocab> component in `stripes-smart-components` so it can work with Refdata-style services as well as regular RMB-based ones. It should Just Work for you. See https://github.com/folio-org/stripes-smart-components/commit/5a95ebb6d69b92ae4946181ad57cc4b9e497e92c |
| Comment by steve.osguthorpe [ 14/Aug/19 ] |
|
md331 Your assumptions are correct with the endpoints. We see this as putting an updated Category. The values list works in the same way as other lists we have in our modules with the "_delete" yes. Although it's actually a put to erm/refdataValues/$ {category ID}{ "values": [ { ... }] } |
| Comment by md331 (Inactive) [ 14/Aug/19 ] |
|
| Comment by Claudia Malzer [ 15/Aug/19 ] |
|
Thank you md331
|
| Comment by Gill Osguthorpe [ 27/Aug/19 ] |
|
QA: Tested in Chrome using the diku_admin account. Critical issue
When attempting to delete a Value which has been used on a license, the following error message is displayed. Note that selecting "OK" closes the window and everything seems to work ok (see the video). Non-critical issues (will be reported as bugs and linked to this issue)
Not implemented. When a new value is added it is displayed in the preview list in alphabetical order. See screen snip: UX: 3. Note that this is an issue with other settings as well (e.g. Users > Patron Groups) The content of the error modal: ... should use the layout of the Error modal pattern:
Not tested
|
| Comment by md331 (Inactive) [ 27/Aug/19 ] |
|
Gill Osguthorpe Claudia Malzer, the UX issues will need to be handled in Stripes itself. We're using the ControlledVocab and EditableList components which control the rendering of those problem areas. Order of display requires the created/updated metadata that pretty much all of our records lack. There's issues out on adding it to Licenses and Agreements (
|
| Comment by Gill Osguthorpe [ 27/Aug/19 ] |
|
Thanks md331. I'll be creating separate tickets for the non-critical issues. Just the Error to fix and then it can pass QA. |
| Comment by Claudia Malzer [ 28/Aug/19 ] |
|
Gill Osguthorpe This error comes from the backend I don't know if and how I can suppress it under certain conditions |
| Comment by Claudia Malzer [ 28/Aug/19 ] |
|
Critical issue: |