[ERM-389] Manage License term value pick lists (refdata categories and values) Created: 11/Aug/19  Updated: 09/Sep/19  Resolved: 09/Sep/19

Status: Closed
Project: ERM Platform
Components: ui-licenses
Affects versions: None
Fix versions: None

Type: Story Priority: TBD
Reporter: Owen Stephens Assignee: steve.osguthorpe
Resolution: Done Votes: 0
Labels: erm
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: PNG File Screenshot 2019-08-12 at 08.00.47.png     Text File mod-licenses-error.txt    
Issue links:
Cloners
clones ERM-391 Manage License term configuration Closed
is cloned by ERM-390 Manage License term value pick list v... Closed
Defines
defines UXPROD-1521 UI for License term configuration Closed
Sprint: ERM Sprint 70, ERM Sprint 71
Development Team: Bienenvolk

 Description   

Administrators can add license term value pick lists (refdata categories) as well as remove them or edit their details.
Only users with access to License settings can view, edit or delete the pick lists available in the tenant

Permission to edit these details are separate to those of other ERM permission sets

Workflow / UI Notes

  • Set from within Settings -> Licenses -> Pick lists
  • Display within Settings -> Licenses -> Pick lists
  • User can view, edit or add a pick list (refdata category)
  • Display in the order pick lists were added to the system

Data stored pick lists (refdata category):

  • Pick List name = Refdata Category desc (short string <50 chars) (required)

Display fields:

  • Display Pick List name
  • Last updated
  • # of Values (number of refdata values in pick list/category)
  • Actions (Edit/Delete)

Business rules/constraints
Pick Lists can only be deleted if they have no Pick List terms

Wireframes
Attached wireframes show UI based on Tenant -> Location setup -> Institutions screens



 Comments   
Comment by steve.osguthorpe [ 12/Aug/19 ]

https://github.com/openlibraryenvironment/ui-directory/blob/master/src/settings/StatusSettings.js

Comment by Claudia Malzer [ 14/Aug/19 ]

steve.osguthorpe
1) I have problems filtering out the refdata categories that belong to the terms. So all refdata categories are displayed at the moment
2) editing and deletion of refdata categories seems to work, but the creation leads to an error
3) how can I list the values of a refdata category? For i.e. DocumentAttachment.AtType I can list the values with curl

licenses/refdata/DocumentAttachment/AtType

but I don't see how this is possible for the categories that relate to the terms

Comment by md331 (Inactive) [ 14/Aug/19 ]

Yeah I think #1 is the key bit here. Right now we're showing things like License.Status and InternalContact.Role in the pick lists which seems....wrong.

Comment by md331 (Inactive) [ 14/Aug/19 ]

Claudia Malzer I think it's looking pretty solid so far though. You can remove the lastUpdated column from both of the ControlledVocab lists though, since the backend doesn't have that data to send us. You can use the hiddenFields prop to do that.

(I can't add comments to a branch so can't leave these comments on Github)

Comment by Claudia Malzer [ 15/Aug/19 ]

steve.osguthorpe I still need help with
1) I have problems filtering out the refdata categories that belong to the terms. So all refdata categories are displayed at the moment
2) editing and deletion of refdata categories seems to work, but the creation leads to an error

Comment by steve.osguthorpe [ 15/Aug/19 ]

Claudia Malzer With regards to #1 You can ignore this for now. We are aware of the issue and Owen Stephens is going to create an enhancement for this in JIRA to be done later.
#2 Can you provide information on what the error is? If it's missing a name then Owen Stephens is aware of that too and I believe it's being discussed on slack.

Comment by Claudia Malzer [ 15/Aug/19 ]

steve.osguthorpe
#2 Do you want to see the output of the mod-licenses-log that's related to the failing save? I attached it
mod-licenses-error.txt

Comment by Claudia Malzer [ 16/Aug/19 ]

steve.osguthorpe all good I found the error:
I tried to add refdata categories manually and it's working if I send an empty array for the values, but it fails without the array.
So I had to experiment with the itemTemplate property of ControlledVocab

Comment by Gill Osguthorpe [ 27/Aug/19 ]

QA:

  • Last updated data does not exist and so cannot be displayed.
  • Devs are unable to control the order of the display and so "Display in the order pick lists were added to the system" is not possible.

I interpreted this:

Business rules/constraints

Pick Lists can only be deleted if they have no Pick List terms

To mean that the Pick List can be deleted if it has Pick List "Values", but cannot be deleted if any of the Values have been applied to a license record.

Generated at Fri Feb 09 00:20:03 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.