[ERM-306] New and Edit Agreement panes: remove placeholder text Created: 19/Jun/19 Updated: 12/Aug/19 Resolved: 12/Aug/19 |
|
| Status: | Closed |
| Project: | ERM Platform |
| Components: | stripes-erm-components, ui-agreements |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Story | Priority: | P3 |
| Reporter: | Gill Osguthorpe | Assignee: | Owen Stephens |
| Resolution: | Done | Votes: | 0 |
| Labels: | agreements, erm, ux-consistency | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue links: |
|
||||||||||||||||
| Sprint: | ERM Sprint 69, ERM Sprint 68 | ||||||||||||||||
| Development Team: | Bienenvolk | ||||||||||||||||
| Description |
|
On the New Agreement pane and Edit Agreement pane, remove the placeholder text from the following fIelds:
In each case, replace placeholder with " " (single space string). This replacement behaviour is based on these fields being mandatory, rather than optional. |
| Comments |
| Comment by Jag Goraya [ 24/Jul/19 ] |
|
Clarified in Slack call that intent is:
|
| Comment by Gill Osguthorpe [ 24/Jul/19 ] |
|
I've asked in the UX channel to see if anyone has tackled the UX issue of selecting a blank. https://folio-project.slack.com/archives/CF9FN94GZ/p1563979806000100?thread_ts=1554882765.001200&cid=CF9FN94GZ |
| Comment by Gill Osguthorpe [ 24/Jul/19 ] |
|
The issue hasn't been addressed by anyone as yet. Filip has suggested adding a clear option (X) in single select fields. This would be a project wide change Jag Goraya. |
| Comment by Gill Osguthorpe [ 31/Jul/19 ] |
|
QA note: the form looks good, just one thing, which is that the Status field is mandatory and so it should not be possible to reset it back to blank. There is an example of this in action.in the Invoices app. Select "New" to open the "Create vendor invoice" pane. The status field is empty: There is no blank option: Claudia Malzer I have checked with Seve and he suggested that Aditya matukumalli may be able to advise what the best approach is for achieving this. |
| Comment by Claudia Malzer [ 31/Jul/19 ] |
|
Gill Osguthorpe I didn't touch the Status field (status of the agreement, right?), and as far as I can see, it's not possible to set it back to blank |
| Comment by Gill Osguthorpe [ 31/Jul/19 ] |
|
We may be talking at cross purposes Claudia Malzer. It's the Agreement Status field which has a blank option. The License Status field works correctly already and has no blank option (although, it has a default and so is a bit different to the Agreement Status, which has no default set). |
| Comment by Claudia Malzer [ 02/Aug/19 ] |
|
Gill Osguthorpe, Owen Stephens: what was the decision for the agreement status value? remove the empty option, but use an empty placeholder? so the empty line is visible but not selectable? |
| Comment by Owen Stephens [ 05/Aug/19 ] |
|
Claudia Malzer |