[ERM-261] Restructure the Agreement accordions Created: 26/Apr/19 Updated: 28/Jun/19 Resolved: 28/Jun/19 |
|
| Status: | Closed |
| Project: | ERM Platform |
| Components: | ui-agreements |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Task | Priority: | P3 |
| Reporter: | Gill Osguthorpe | Assignee: | Aditya matukumalli |
| Resolution: | Done | Votes: | 0 |
| Labels: | erm | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue links: |
|
||||||||
| Sprint: | ERM Sprint 66 | ||||||||
| Story Points: | 2 | ||||||||
| Development Team: | Bienenvolk | ||||||||
| Description |
|
Filip has suggested that sub-accordions should be avoided if possible. They can either: The attached mockup shows how the Agreement might be restructured. Note that empty accordions have also been removed. Changes made are:
|
| Comments |
| Comment by Gill Osguthorpe [ 17/Jun/19 ] |
|
[copied from Slack] Aditya Matukumalli Gill Osguthorpe Thank you for moving the 'Agreement information' section out of the accordion. I can't see what you've done but the changes to make are:
Thanks for moving Internal Contacts. 'All licenses' needs to come out of its sub-accordion and simply become part of the main 'License information' section. No heading is needed. 'External license' needs to come out of its sub-accordion and become part of the main 'License information' section, but with a sub-heading 'External licenses'. Note that sub-headings need to be styled on both the Edit pane and the Preview pane. I'm not sure which style this is md331 may be able to advise. I think that's all on the Edit Agreement pane, give me a shout if you have any more questions. |
| Comment by Gill Osguthorpe [ 17/Jun/19 ] |
|
Update: Agreed with Aditya matukumalli it it best to not apply heading styles to form fields for now and wait to see if it is going to be applied by the other apps. |
| Comment by Gill Osguthorpe [ 18/Jun/19 ] |
|
Aditya matukumalli, md331 and I have been discussing the styling of sub-headings. In this snip the three sub-headings below should all use the headline component described in the Storybook: https://ux.folio.org/storybook/?selectedKind=Headline&selectedStory=Basic%20Usage&full=0&addons=1&stories=1&panelRight=0&addonPanel=REACT_STORYBOOK%2Freadme%2Fpanel:
They should have the "medium" size applied and be tagged as "h4". Mark uses margin="none" on areas like these. I'm not sure whether or not they need a fade.We're aiming for the sub-headings to be smaller than the Accordion headings but larger than the main text. Please don't worry about making the "Controlling license" sub-heading look better. Mark has noticed that the accordion/button styling is interfering with it, and also we're changing this soon (it will become a heading in a license card). If you could sort the other two out that would be great. |