[ERM-109] Support the ability to create an Agreement from the eholdings app Created: 01/Mar/19 Updated: 08/Apr/19 Resolved: 08/Apr/19 |
|
| Status: | Closed |
| Project: | ERM Platform |
| Components: | ui-agreements |
| Affects versions: | None |
| Fix versions: | None |
| Type: | Story | Priority: | P3 |
| Reporter: | Khalilah Gambrell | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | eholdings_integration, erm | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original estimate: | Not Specified |
| Issue links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Sub-tasks: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Sprint: | ERM Sprint 60 | ||||||||||||||||||||||||||||||||||||||||||||
| Development Team: | Bienenvolk | ||||||||||||||||||||||||||||||||||||||||||||
| Description |
|
As a Librarian Requirement
See eholdings requirements |
| Comments |
| Comment by Khalilah Gambrell [ 12/Mar/19 ] |
|
Ian Ibbotson (Use this one) to support
|
| Comment by Jag Goraya [ 15/Mar/19 ] |
|
There is no current way for sharing data as needed. Two options are being discussed between md331, Igor Godlevskyi and Yurii Danylenko. There are some unknowns to be addressed before we can make a decision or estimate.
|
| Comment by Jag Goraya [ 19/Mar/19 ] |
|
Hi Khalilah Gambrell - can you confirm the option we're taking for this and assign to the team member best placed to furnish the info needed please? Thx |
| Comment by Khalilah Gambrell [ 19/Mar/19 ] |
|
Igor Godlevskyi and Yurii Danylenko, can one of describe what has been agreed upon to implement this story? Also does md331 know which mod-kb-ebscojava endpoints he will us? |
| Comment by Igor Godlevskyi (Inactive) [ 19/Mar/19 ] |
|
Hi Khalilah Gambrell, as we discussed we would stick to the 1st option for now as it is currently a "folio way" and the 2dn option will require some time for the spike/investigation. Regarding the 1st aproach: Regarding the endpoints for md331, Just need to find the modkbebskojava section. And check the view1 links. |
| Comment by Sobha Duvvuri [ 19/Mar/19 ] |
|
This might be additional information but ids in eHoldings are a combination : For packages -> {providerId-packageId}For resources -> {providerId-packageId-titleId}While it may be fine as a first step on ERM's side to save the complete id and corresponding agreement information in the data model, for another requirement of displaying all associated agreements of a provider, ERM might also want to consider a data model for saving relationship between providerId and all agreements associated with that providerId for eHoldings to be able to fetch all agreements associated with a provider. There might be another user story associated with this though. |
| Comment by md331 (Inactive) [ 19/Mar/19 ] |
|
This is still not super clear to me. Here's my understanding for what the ui-agreements code will do when the Create Agreement page loads. I'm basing this off of going through the eholdings code.
Please confirm that those steps are correct for both packages/titles. |
| Comment by md331 (Inactive) [ 19/Mar/19 ] |
|
For step #3 above, we currently render a Name, Type, Titles (count), and Platform. According to this page, I assume I can pull Name from attributes.name and Type from attributes.publicationType, but I'm not sure about the count of Titles if the added resource is a package. Also, I don't know what was decided about Platform. Originally I heard to hide it, then I heard that it may map to the Provider (attributes.providerName ?). Owen Stephens or Khalilah Gambrell, do we know what we're doing with that field? |
| Comment by Sobha Duvvuri [ 19/Mar/19 ] |
|
md331: Yes, the above steps are correct. Just to add some more detail on the specific endpoints to be used for fetching packages/resources, please see below: |
| Comment by Khalilah Gambrell [ 19/Mar/19 ] |
|
md331 - I defer to Owen Stephens on this question: "Also, I don't know what was decided about Platform. Originally I heard to hide it, then I heard that it may map to the Provider (attributes.providerName ?). Owen Stephens or Khalilah Gambrell, do we know what we're doing with that field?" |
| Comment by Owen Stephens [ 19/Mar/19 ] |
|
md331 I added the list of columns for Agreement lines (going forward) to https://folio-org.atlassian.net/browse/ERM-119 this morning. We need to agree where "Provider" comes from on the ERM/Agreement side - which is a conversation with Ian Ibbotson (Use this one) and me I think. |
| Comment by Khalilah Gambrell [ 19/Mar/19 ] |
|
md331 |
| Comment by md331 (Inactive) [ 19/Mar/19 ] |
|
OK, I'm all clear on the endpoints now. So the support I'm planning on implementing from the Agreements is that when the Create Agreement page loads, I will look on the query string for two optional parameters:
The data from those endpoints will only be used for the rendering of the agreement lines in the Create Agreement page. Subsequent fetches will be routed via mod-agreements functionality Ian Ibbotson (Use this one) is working on. The reference key I'm passing in the items array will be the resourceId or packageId I get on the query string. Igor Godlevskyi, Yurii Danylenko, are y'all on board with those parameters? |