Poppy 2023 R2 - Upgrade to Java 17
(FOLIO-3783)
|
|
| Status: | Closed |
| Project: | edge-oai-pmh |
| Components: | None |
| Affects versions: | None |
| Fix versions: | 2.7.0 | Parent: | Poppy 2023 R2 - Upgrade to Java 17 |
| Type: | Task | Priority: | TBD |
| Reporter: | Oleksii Petrenko | Assignee: | Dmytro Bykov |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||
| Issue links: |
|
||||||||||||||||
| Sprint: | Firebird - Sprint 173 | ||||||||||||||||
| Story Points: | 2 | ||||||||||||||||
| Development Team: | Firebird | ||||||||||||||||
| Release: | Poppy (R2 2023) | ||||||||||||||||
| Epic Link: | Poppy 2023 R2 - Upgrade to Java 17 | ||||||||||||||||
| RCA Group: | TBD | ||||||||||||||||
| Description |
|
Purpose/Overview: Acceptance criteria:
|
| Comments |
| Comment by Dmytro Bykov [ 28/Aug/23 ] |
|
During the compilation under Java 11, the project triggers the warning(below) at the stage of java classes generation by the org.folio.raml-module-builder Migration of the project to Java 17 with the following changes applied https://github.com/folio-org/edge-oai-pmh/pull/99/files
The total error stack trace is attached. The root cause of such an issue is that the file-generation process goes through the but the same Java file-generation flow in the https://github.com/folio-org/mod-data-export project works successfully under Java 17 because it passes org.raml.jaxrs.generator.v10.types.V10GTypeJson but not V10GTypeXml The suggestion regarding further steps in the Java 17 migration flow scope is needed. Thanks. |
| Comment by Dmytro Bykov [ 28/Aug/23 ] |
|
Processing raml schemas, the raml-module builder dealing with two kinds of objectType: JSON_OBJECT_TYPE and XML_OBJECT_TYPE.
org.raml.jaxrs.generator.builders.JAXBHelper is involved in file generation flow by V10GTypeXml, and currently ruins encapsulation of Java internals. |
| Comment by Dmytro Bykov [ 31/Aug/23 ] |
|
Karate - tests result |
| Comment by Yauheniya Kryshtafovich [ 08/Sep/23 ] |
|
Hi, Magda Zacharska and Dmytro Bykov the smoke verification was done on Snapshot: 2. Start harvesting with verb=ListRecords&metadataPrefix=marc21_withholdings 4. Full harvesting was done on Sprint testing env (tenant fs09000000) for Inventory: marc21 and marc21_withholdings: |