Requests (UXPROD-790)

[CIRC-1759] TLR: Recall returns 500 error in some scenarios Created: 20/Mar/23  Updated: 23/May/23  Resolved: 24/Mar/23

Status: Closed
Project: mod-circulation
Components: None
Affects versions: None
Fix versions: 23.5.3
Parent: Requests

Type: Bug Priority: P2
Reporter: Stephanie Buck Assignee: Alexander Kurash
Resolution: Done Votes: 0
Labels: bugfest_R1.2023
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified

Attachments: File C380488.mp4     File C380490.mp4     File CIRC-1759_retest1.mp4     File CIRC-1759_retest2.mp4     PNG File awaiting pickup checked out.png    
Issue links:
Defines
defines UXPROD-3811 Vega - Orchid Enhancements/Bugfixes/T... Closed
Relates
relates to FAT-5219 Review of C380490 test case Closed
relates to FAT-5218 Review of C380488 test case Closed
Sprint: EPAM-Veg Sprint 161, EPAM-Veg Sprint 162
Story Points: 2
Development Team: Vega
Release: Orchid (R1 2023) Bug Fix
Epic Link: Requests
RCA Group: Implementation coding issue
Affected releases:
Orchid (R1 2023)

 Description   

Overview: 

In some circumstances FOLIO returns an error for recalls. This can be reproduced using the steps below, but the steps can probably be simplified.

These are not edge cases but rather very common scenarios. I have not involved In transit and other statuses, but would not be surprised if the error would appear also when they are part of the scenario.

Steps to Reproduce: (Items awaiting pickup and checked out)

  1. Instance with two items. Both available.
  2. TLR Page - Item A is paged. Patron 1
  3. Item A is Checked in at chosen SP and becomes Awaiting pickup for Patron 1
  4. Item B is Checked out to Patron 2.
  5. A TLR Recall is placed for Patron 3
    The checked out item B is being recalled.
  6. Item A that is Awaiting pickup is checked out to the patron with the request
  7. Item B is checked in and becomes Awaiting pickup for the first patron in queue
  8. A recall is placed Patron 4
    The checked out Item A is being recalled.
  9. A recall is placed. Patron 5

Expected Results:

To get a success banner for the recall request in step 9.
 
Actual Results:

A red banner "this request was not placed successfully" / http 500 internal server error

Additional Information: 

It is possible to place hold requests at step 9, but not recall requests.

As holds are always allowed with TLR and the request is placed through the discovery system EDS, it will become a hold and trigger a successful message to the patron. However, the loan period will not be as expected when there is a mix of recall and hold requests at the same instance, so it's not a acceptable outcome.

Steps to Reproduce: (paged and checked out)

  1. An instance with 2 items. Both Paged. Patron 1, Patron 2
  2. 2 recalls placed Patron 3, Patron 4
    Both recalling Item A
  3. Item B is checked in at chosen SP – Awaiting pickup.
  4. Item B is checked out
  5. A recall is placed. Patron 5
    Recalling the checked out Item B
  6. A recall is placed. Patron 6
    Recalling the checked out Item B
  7. A recall is placed. Patron 7

Expected Results: 

To get a success banner for the recall request in step 7

Actual Results:

a red banner ”this request was not placed successfully” / http 500 internal server error

Additional Information:
URL:
Interested parties: Marie Widigson 



 Comments   
Comment by Stephanie Buck [ 20/Mar/23 ]

Discovered while testing other TLR test cases. There is no current test case for this. 

Comment by Haykanush Markosyan [ 24/Mar/23 ]

Both scenarios are tested in snapshot environment.

Attached you can find the recordings => C380488.mp4, C380490.mp4.

 

Comment by JenkinsNotifications [ 28/Mar/23 ]

Deployed to Orchid bf env. Moved status to In bugfix review from status Awaiting deployment. Please proceed with verification

Comment by Haykanush Markosyan [ 29/Mar/23 ]

I have retested both scenarios in bugfest environment. Works as expected.

Attached you can find the recordings: CIRC-1759_retest1.mp4, CIRC-1759_retest2.mp4.

 

Comment by Oleksandr Hrusha [ 29/Mar/23 ]

Hello Stephanie Buck, could you please confirm fix on bugfest env?

Generated at Fri Feb 09 00:37:38 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.