[CIRC-1463] Renewing Items Does Not Change Due Date Created: 09/Mar/22  Updated: 28/Jun/22  Resolved: 04/Apr/22

Status: Closed
Project: mod-circulation
Components: None
Affects versions: None
Fix versions: 23.0.8, 23.1.0

Type: Bug Priority: P3
Reporter: Michael Paulmeno Assignee: Sergiy Bichurin
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original estimate: Not Specified
Environment:

Tested on Juniper release.


Attachments: PNG File FOLIO Juniper test loan.png     PNG File Skidmore test fixed due date schedule.png     PNG File Skidmore test loan policy.png     File test loan.json    
Issue links:
Duplicate
is duplicated by CIRC-1521 Rolling Due Date Loans with Fixed Due... Closed
Sprint: EPAM-Veg Sprint 136
Story Points: 3
Development Team: Vega
Release: Lotus (R1 2022) Bug Fix
Potential Workaround: Our workaround is to run an overdue loans report and filter by items due the date the fixed due date schedule ends. We then check items in and back out again, then waive any over due fines. We also notify the patron (assuming them have not contacted us first) of having corrected the error.
Affected Institution:
Skidmore College
RCA Group: TBD

 Description   

Overview: We've noticed some odd behavior when checking out materials using loan policies with fixed due date schedules attached.  The situation occurs when a user wishes to renew an item after its due date (truncated by the schedule), but the original date range is passed.   In cases where a new date range applies and when one renews the item, one would expect the new due date to equal the one set by the new date range in the fixed due date schedule.  However the renewal has no effect and the due date remains unchanged.

Steps to Reproduce:

  1. Log into a FOLIO environment as a user with check in/check out privileges
  2. Create a fixed due date schedule with two date ranges A and B.  The two ranges should not overlap (see screenshot below).
  3. Create a loan policy X with the above fixed due date schedule attached.  It should allow at least 2 renewals and renew from the system date.
  4. Log into your FOLIO environment a short period of time before date range A ends.  The loan period for policy X should be greater than date range A so the policy truncates the loan period.
  5. Check out an item to which loan policy X applies. 
  6. Wait until after date range A ends and date range B begins.
  7. Log back into the same environment and renew your item.

Expected Results: The item due date changes to the one set by range B.
Actual Results: The item due date remains the same.
Additional Information:

Tested on both Skidmore's FOLIO instance and Juniper snapshot
URL: https://folio-juniper.dev.folio.org

Interested parties:
Skidmore College



 Comments   
Comment by Stephanie Buck [ 10/Mar/22 ]

Hi Michael Paulmeno. How much of an interruption to your workflow does this cause? When does Skidmore anticipate upgrading to Kiwi?
cc: Kyle Banerjee

Comment by Michael Paulmeno [ 10/Mar/22 ]

Stephanie Buck We're hosted by EBSCO so we will receive the Kiwi upgrade when the hosting team sets a date for us to upgrade.

The bug doesn't cause interruption per se, but adds to our workload.  The approach which works for us is to manually check items in and out.  I've update the ticket with the workaround.  As far as I know it's feasible for us to go this route, but we are a fairly small library.  A larger institution may find the workaround more onerous.  Our evening supervisor will have more information and I will update the ticket after we are able to speak with zir.

Comment by julie.bickle [ 31/Mar/22 ]

Sergiy Bichurin FYI: Here's the conversation that prompted the ticket: https://folio-project.slack.com/archives/C3G05TF3R/p1646842617812669

And here's Natalia's original question: https://folio-project.slack.com/archives/C3G05TF3R/p1646341225152919 

Comment by Sergiy Bichurin [ 31/Mar/22 ]

Hello Cheryl Malmborg cc Stephanie Buck julie.bickle Michael Paulmeno
The scenario is perfectly described for loan policy with option Renew from System Date.

But it would be great to recheck within the ticket the system behavior correctness for equal loan policy but with option Renew from Current Due Date. Could you please let me know which correct behavior should be for the schedules from the initial screen:

1_ if we have loan with checkout date on 06.03.2022 and attempt to renew it;

2_ if we have loan with checkout date on 10.03.2022 and attempt to renew it;

Comment by Cheryl Malmborg [ 31/Mar/22 ]

Sergiy Bichurin I think in both cases the due date would not change as long as the renewal date fell inside the the fixed due date range. That is, an item checked out on 06.03.2022 would be due on 08.03.2022. If a renewal was attempted between 06 and 08, the due date would not change. The renewal should actually fail with the message that the due date would not change.

Comment by Michael Paulmeno [ 31/Mar/22 ]

Sergiy Bichurin Cheryl Malmborg I tried this on Juniper snapshot and was able to renew the loan.  The policy included a 2 week checkout period for books and a fixed due dates schedule which ended on April 15.  I set "renew from current due date" in the loan policy and the renewal period is the same as the original loan.  Initially the book was due April 14.  When I renewed it, the due date changed to April 15.

Comment by Sergiy Bichurin [ 01/Apr/22 ]

Cheryl MalmborgThanks a lot, it will help!

Michael Paulmeno Sorry, I am not sure that understood the scenario for 100%, could you please attach screens of your loan policy and fixed due dates schedule?

Comment by Michael Paulmeno [ 01/Apr/22 ]

Sergiy Bichurin I was checking to see what would happen if I followed the steps to reproduce the error, but with a policy which is set to renew from current due date instead of from the system date.  However yesterday I was setting the loan period to be too short so it wasn't being truncated by the loan policy.  Today I change the loan period to be 56 days and repeated what I did yesterday.  This time the book would not renew with the message "Item not renewed: renewal date falls outside of date ranges in the loan policy" .

So you should probably ignore my comment yesterday as Cheryl Malmborg is probably right regarding the renewal date not changing if you are operating within a fixed due date schedule. 

Comment by Sergiy Bichurin [ 01/Apr/22 ]

Thank you

Comment by Sergiy Bichurin [ 03/Apr/22 ]

Hello Michael Paulmeno , the issue is fixed and checked the work at snapshot host. It works as expected.

Could you please check from your side and let me know that the ticket can be closed?

If you need any support to move loan and due date backward via API to test faster, please, let me know.

Comment by Brooks Travis [ 04/Apr/22 ]

This does now appear to be working in Lotus Bugfest and snapshot, just FYI, Michael Paulmeno Sergiy Bichurin

Comment by Michael Paulmeno [ 04/Apr/22 ]

Thank you for testing this Brooks Travis

Generated at Thu Feb 08 23:28:10 UTC 2024 using Jira 1001.0.0-SNAPSHOT#100246-sha1:7a5c50119eb0633d306e14180817ddef5e80c75d.